suyu/breakpad
26
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Breakpad DWARF parser: Don't use auto_ptr<stack<uint64> > where stack<uint64> would do.

Browse source 
Perhaps there once was some reason one needed the DIE offset stack to
have an unusual lifetime, but there is none now.

a=jimblandy, r=mmentovai


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@666 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
jimblandy 2010-08-25 15:10:19 +00:00
parent 16f2f37682
commit 42943c2391
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/common/dwarf/dwarf2reader.cc
View file

@ -39,7 +39,6 @@
#include <string.h>
#include <map>
#include <memory>
#include <stack>
#include <utility>
@ -494,11 +493,8 @@ void CompilationUnit::ProcessDIEs() {
else
lengthstart += 4;
// we need semantics of boost scoped_ptr here - no intention of trasnferring
// ownership of the stack. use const, but then we limit ourselves to not
// ever being able to call .reset() on the smart pointer.
std::auto_ptr<stack<uint64> > const die_stack(new stack<uint64>);
stack<uint64> die_stack;
while (dieptr < (lengthstart + header_.length)) {
// We give the user the absolute offset from the beginning of
// debug_info, since they need it to deal with ref_addr forms.
@ -510,8 +506,8 @@ void CompilationUnit::ProcessDIEs() {
// Abbrev == 0 represents the end of a list of children.
if (abbrev_num == 0) {
const uint64 offset = die_stack->top();
die_stack->pop();
const uint64 offset = die_stack.top();
die_stack.pop();
handler_->EndDIE(offset);
continue;
}
@ -525,7 +521,7 @@ void CompilationUnit::ProcessDIEs() {
}
if (abbrev.has_children) {
die_stack->push(absolute_offset);
die_stack.push(absolute_offset);
} else {
handler_->EndDIE(absolute_offset);
}