ryujinx-backup/Ryujinx
3
6
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Address PR feedback

Browse source 
Add TODO comment for GL_EXT_polygon_offset_clamp
This commit is contained in:
gdkchan 2020-01-05 22:04:37 -03:00 committed by Thog
parent 383452f5cf
commit 18814d44b2
16 changed files with 104 additions and 101 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Ryujinx.Common/Utilities/EmbeddedResources.cs
View file

@ -38,6 +38,7 @@ namespace Ryujinx.Common
using (var mem = new MemoryStream()) using (var mem = new MemoryStream())
{ {
stream.CopyTo(mem); stream.CopyTo(mem);
return mem.ToArray(); return mem.ToArray();
} }
} }
@ -53,6 +54,7 @@ namespace Ryujinx.Common
using (var mem = new MemoryStream()) using (var mem = new MemoryStream())
{ {
await stream.CopyToAsync(mem); await stream.CopyToAsync(mem);
return mem.ToArray(); return mem.ToArray();
} }
} }

1
Ryujinx.Graphics.OpenGL/Pipeline.cs
View file

@ -471,6 +471,7 @@ namespace Ryujinx.Graphics.OpenGL
} }
GL.PolygonOffset(factor, units); GL.PolygonOffset(factor, units);
// TODO: Enable when GL_EXT_polygon_offset_clamp is supported.
// GL.PolygonOffsetClamp(factor, units, clamp); // GL.PolygonOffsetClamp(factor, units, clamp);
} }

4
Ryujinx.Graphics.Shader/Instructions/InstEmitConversion.cs
View file

@ -60,7 +60,7 @@ namespace Ryujinx.Graphics.Shader.Instructions
if (intType == IntegerType.U64) if (intType == IntegerType.U64)
{ {
// TODO: Warning. This instruction supports 64-bits integers, but it is not implemented. context.Config.PrintLog("Unimplemented 64-bits F2I.");
return; return;
} }
@ -172,7 +172,7 @@ namespace Ryujinx.Graphics.Shader.Instructions
if (srcType == IntegerType.U64 || dstType == IntegerType.U64) if (srcType == IntegerType.U64 || dstType == IntegerType.U64)
{ {
// TODO: Warning. This instruction doesn't support 64-bits integers. context.Config.PrintLog("Invalid I2I encoding.");
return; return;
} }

4
Ryujinx.Graphics.Shader/Instructions/InstEmitHelper.cs
View file

@ -53,10 +53,10 @@ namespace Ryujinx.Graphics.Shader.Instructions
} }
else if (floatType == FPType.FP64) else if (floatType == FPType.FP64)
{ {
// TODO. // TODO: Double floating-point type support.
} }
// TODO: Warn about invalid floating point type. context.Config.PrintLog($"Invalid floating point type: {floatType}.");
return ConstF(0); return ConstF(0);
} }

2
Ryujinx.Graphics.Shader/Instructions/InstEmitMemory.cs
View file

@ -198,7 +198,7 @@ namespace Ryujinx.Graphics.Shader.Instructions
if (!(emit || cut)) if (!(emit || cut))
{ {
// TODO: Warning. context.Config.PrintLog("Invalid OUT encoding.");
} }
if (emit) if (emit)

2
Ryujinx.Graphics.Shader/Translation/Translator.cs
View file

@ -22,8 +22,6 @@ namespace Ryujinx.Graphics.Shader.Translation
if (cfg == null) if (cfg == null)
{ {
// TODO: Error.
return code; return code;
} }

2
Ryujinx.HLE/HOS/Services/Nv/NvDrvServices/NvHostChannel/NvHostChannelDeviceFile.cs
View file

@ -15,7 +15,9 @@ namespace Ryujinx.HLE.HOS.Services.Nv.NvDrvServices.NvHostChannel
private uint _timeout; private uint _timeout;
private uint _submitTimeout; private uint _submitTimeout;
private uint _timeslice; private uint _timeslice;
private GpuContext _gpu; private GpuContext _gpu;
private ARMeilleure.Memory.MemoryManager _memory; private ARMeilleure.Memory.MemoryManager _memory;
public NvHostChannelDeviceFile(ServiceCtx context) : base(context) public NvHostChannelDeviceFile(ServiceCtx context) : base(context)