From a875bfe6b9d97731804a4a0aa1a1a89863618d95 Mon Sep 17 00:00:00 2001 From: Unknown Date: Wed, 3 Jan 2018 20:36:29 +0100 Subject: [PATCH] Restructured Quaternion tests --- tests/OpenTK.Tests.Math/QuaternionTests.cs | 217 ++++++++++++--------- 1 file changed, 124 insertions(+), 93 deletions(-) diff --git a/tests/OpenTK.Tests.Math/QuaternionTests.cs b/tests/OpenTK.Tests.Math/QuaternionTests.cs index 3db06f30..1f078d32 100644 --- a/tests/OpenTK.Tests.Math/QuaternionTests.cs +++ b/tests/OpenTK.Tests.Math/QuaternionTests.cs @@ -7,121 +7,152 @@ namespace OpenTK.Tests.Math public class Quaternion_Tests { /// - /// Checks if a single given value (either pitch, yaw or roll) get converted into correct x,y,z value of quaternion. + /// Contains all tests which cover the ctor of Quaternion. /// - /// euler angle values - /// expected xyz component of quaternion - /// Taken from nUnit test data. Don't know how to name data driven tests for xUnit which actually works. - [Theory] - [MemberData(nameof(QuaternionTestDataGenerator.SingleAxisTestCases), MemberType = typeof(QuaternionTestDataGenerator))] - public void CtorEulerAnglesFloat_SingleEulerAngleSet_RotateCorrectAxis(Vector3 eulerValues, Vector3 expectedResult, string testName) + public class Constructor_Tests { - //Arrange + Act: Create Quaternion with "pitch/yaw/roll" - var cut = new Quaternion(eulerValues.X, eulerValues.Y, eulerValues.Z); + /// + /// Checks if a single given value (either pitch, yaw or roll) get converted into correct x,y,z value of quaternion. + /// + /// euler angle values + /// expected xyz component of quaternion + /// Taken from nUnit test data. Don't know how to name data driven tests for xUnit which actually works. + [Theory] + [MemberData(nameof(QuaternionTestDataGenerator.SingleAxisTestCases), MemberType = typeof(QuaternionTestDataGenerator))] + public void SingleAxisAsEulerAnglesInFloatsIsConvertedToCorrectValueInQuaternion + (Vector3 eulerValues, Vector3 expectedResult, string testName) + { + //Arrange + Act: Create Quaternion with "pitch/yaw/roll" + var cut = new Quaternion(eulerValues.X, eulerValues.Y, eulerValues.Z); - //Assert: Use helper, to check if part of the two correct axis is zero. I just want check the direction - Vector3 resultXYZ = cut.Xyz; + //Assert: Use helper, to check if part of the two correct axis is zero. I just want check the direction + Vector3 resultXYZ = cut.Xyz; - Assert.True(QuaternionTestHelper.VerifyEqualSingleDirection(resultXYZ, expectedResult)); + Assert.True(QuaternionTestHelper.VerifyEqualSingleDirection(resultXYZ, expectedResult)); + } + + /// + /// Checks if a single given value (either pitch, yaw or roll) get converted into correct x,y,z value of quaternion. + /// + /// euler angle values + /// expected xyz component of quaternion + /// Taken from nUnit test data. Don't know how to name data driven tests for xUnit which actually works. + [Theory] + [MemberData(nameof(QuaternionTestDataGenerator.SingleAxisTestCases), MemberType = typeof(QuaternionTestDataGenerator))] + public void SingleAxisAsEulerAnglesInVector3IsConvertedToCorrectValueInQuaternion + (Vector3 eulerValues, Vector3 expectedResult, string testName) + { + //Arrange + Act: Create Quaternion with "pitch/yaw/roll" + var cut = new Quaternion(eulerValues); + + //Assert: Use helper, to check if part of the two correct axis is zero. I just want check the direction + Vector3 resultXYZ = cut.Xyz; + + Assert.True(QuaternionTestHelper.VerifyEqualSingleDirection(resultXYZ, expectedResult)); + } + + //TODO: Make also checks with ccw rotation angle and correct applied rotation order of multiple axis } /// - /// Checks if a single given value (either pitch, yaw or roll) get converted into correct x,y,z value of quaternion. + /// Contains all tests for FromEulerAngles /// - /// euler angle values - /// expected xyz component of quaternion - /// Taken from nUnit test data. Don't know how to name data driven tests for xUnit which actually works. - [Theory] - [MemberData(nameof(QuaternionTestDataGenerator.SingleAxisTestCases), MemberType = typeof(QuaternionTestDataGenerator))] - public void CtorEulerAnglesVector3_SingleEulerAngleSet_RotateCorrectAxis(Vector3 eulerValues, Vector3 expectedResult, string testName) + public class FromEulerAngles_Tests { - //Arrange + Act: Create Quaternion with "pitch/yaw/roll" - var cut = new Quaternion(eulerValues); + /// + /// Checks if a single given value (either pitch, yaw or roll) get converted into correct x,y,z value of quaternion. + /// + /// euler angle values + /// expected xyz component of quaternion + /// Taken from nUnit test data. Don't know how to name data driven tests for xUnit which actually works. + [Theory] + [MemberData(nameof(QuaternionTestDataGenerator.SingleAxisTestCases), MemberType = typeof(QuaternionTestDataGenerator))] + public void SingleAxisAsEulerAnglesInFloatsIsConvertedToCorrectValueInQuaternion + (Vector3 eulerValues, Vector3 expectedResult, string testName) + { + //Arrange + Act: Create Quaternion with "pitch/yaw/roll" + var cut = Quaternion.FromEulerAngles(eulerValues.X, eulerValues.Y, eulerValues.Z); - //Assert: Use helper, to check if part of the two correct axis is zero. I just want check the direction - Vector3 resultXYZ = cut.Xyz; + //Assert: Use helper, to check if part of the two correct axis is zero. I just want check the direction + Vector3 resultXYZ = cut.Xyz; - Assert.True(QuaternionTestHelper.VerifyEqualSingleDirection(resultXYZ, expectedResult)); + Assert.True(QuaternionTestHelper.VerifyEqualSingleDirection(resultXYZ, expectedResult)); + } + + /// + /// Checks if a single given value (either pitch, yaw or roll) get converted into correct x,y,z value of quaternion. + /// + /// euler angle values + /// expected xyz component of quaternion + /// Taken from nUnit test data. Don't know how to name data driven tests for xUnit which actually works. + [Theory] + [MemberData(nameof(QuaternionTestDataGenerator.SingleAxisTestCases), MemberType = typeof(QuaternionTestDataGenerator))] + public void SingleAxisAsEulerAnglesInVector3IsConvertedToCorrectValueInQuaternion + (Vector3 eulerValues, Vector3 expectedResult, string testName) + { + //Arrange + Act: Create Quaternion with "pitch/yaw/roll" + var cut = Quaternion.FromEulerAngles(eulerValues); + + //Assert: Use helper, to check if part of the two correct axis is zero. I just want check the direction + Vector3 resultXYZ = cut.Xyz; + + Assert.True(QuaternionTestHelper.VerifyEqualSingleDirection(resultXYZ, expectedResult)); + } + + /// + /// Checks if a single given value (either pitch, yaw or roll) get converted into correct x,y,z value of quaternion. + /// + /// euler angle values + /// expected xyz component of quaternion + /// Taken from nUnit test data. Don't know how to name data driven tests for xUnit which actually works. + [Theory] + [MemberData(nameof(QuaternionTestDataGenerator.SingleAxisTestCases), MemberType = typeof(QuaternionTestDataGenerator))] + public void SingleAxisAsEulerAnglesInVector3IsConvertedToCorrectValueInQuaternionAsOutParam + (Vector3 eulerValues, Vector3 expectedResult, string testName) + { + //Arrange + Act: Create Quaternion with "pitch/yaw/roll" + var cut = Quaternion.Identity; + Quaternion.FromEulerAngles(ref eulerValues, out cut); + + //Assert: Use helper, to check if part of the two correct axis is zero. I just want check the direction + Vector3 resultXYZ = cut.Xyz; + + Assert.True(QuaternionTestHelper.VerifyEqualSingleDirection(resultXYZ, expectedResult)); + } + + //TODO: Make also checks with ccw rotation angle and correct applied rotation order of multiple axis } + /// - /// Checks if a single given value (either pitch, yaw or roll) get converted into correct x,y,z value of quaternion. + /// Contains all test for ToAxisAngle /// - /// euler angle values - /// expected xyz component of quaternion - /// Taken from nUnit test data. Don't know how to name data driven tests for xUnit which actually works. - [Theory] - [MemberData(nameof(QuaternionTestDataGenerator.SingleAxisTestCases), MemberType = typeof(QuaternionTestDataGenerator))] - public void FromEulerAnglesFloat_SingleEulerAngleSet_RotateCorrectAxis(Vector3 eulerValues, Vector3 expectedResult, string testName) + public class ToAxisAngle { - //Arrange + Act: Create Quaternion with "pitch/yaw/roll" - var cut = Quaternion.FromEulerAngles(eulerValues.X, eulerValues.Y, eulerValues.Z); + /// + /// Check if a quaternion returns a a rotation about the correct coordinate axis + /// + /// Prepared Quaternion + /// Expected result. + /// Taken from nUnit test data. Don't know how to name data driven tests for xUnit which actually works. + [Theory] + [MemberData(nameof(QuaternionTestDataGenerator.ToAxisAngleTestCases), MemberType = typeof(QuaternionTestDataGenerator))] + public void PreparedSingleRotationAxisQuaternionConvertsToCorrectAxisAngleRepresentation(Quaternion cut, Vector3 expectedResult, string testName) + { + //Arrange + Act: Create Quaternion with rotation about X/Y/Z axis + Vector3 resultXYZ; + float dontCare; + cut.ToAxisAngle(out resultXYZ, out dontCare); - //Assert: Use helper, to check if part of the two correct axis is zero. I just want check the direction - Vector3 resultXYZ = cut.Xyz; + //Assert: Use helper, to check if part of the two correct axis is zero. I just want check the direction + Assert.True(QuaternionTestHelper.VerifyEqualSingleDirection(resultXYZ, expectedResult)); + } - Assert.True(QuaternionTestHelper.VerifyEqualSingleDirection(resultXYZ, expectedResult)); + //TODO: Make also checks with ccw rotation angle and correct applied rotation order of multiple axis } - /// - /// Checks if a single given value (either pitch, yaw or roll) get converted into correct x,y,z value of quaternion. - /// - /// euler angle values - /// expected xyz component of quaternion - /// Taken from nUnit test data. Don't know how to name data driven tests for xUnit which actually works. - [Theory] - [MemberData(nameof(QuaternionTestDataGenerator.SingleAxisTestCases), MemberType = typeof(QuaternionTestDataGenerator))] - public void FromEulerAnglesVector3_SingleEulerAngleSet_RotateCorrectAxis(Vector3 eulerValues, Vector3 expectedResult, string testName) - { - //Arrange + Act: Create Quaternion with "pitch/yaw/roll" - var cut = Quaternion.FromEulerAngles(eulerValues); - //Assert: Use helper, to check if part of the two correct axis is zero. I just want check the direction - Vector3 resultXYZ = cut.Xyz; - Assert.True(QuaternionTestHelper.VerifyEqualSingleDirection(resultXYZ, expectedResult)); - } - - /// - /// Checks if a single given value (either pitch, yaw or roll) get converted into correct x,y,z value of quaternion. - /// - /// euler angle values - /// expected xyz component of quaternion - /// Taken from nUnit test data. Don't know how to name data driven tests for xUnit which actually works. - [Theory] - [MemberData(nameof(QuaternionTestDataGenerator.SingleAxisTestCases), MemberType = typeof(QuaternionTestDataGenerator))] - public void FromEulerAnglesOut_SingleEulerAngleSet_RotateCorrectAxis(Vector3 eulerValues, Vector3 expectedResult, string testName) - { - //Arrange + Act: Create Quaternion with "pitch/yaw/roll" - var cut = Quaternion.Identity; - Quaternion.FromEulerAngles(ref eulerValues, out cut); - - //Assert: Use helper, to check if part of the two correct axis is zero. I just want check the direction - Vector3 resultXYZ = cut.Xyz; - - Assert.True(QuaternionTestHelper.VerifyEqualSingleDirection(resultXYZ, expectedResult)); - } - - /// - /// Check if a quaternion returns a a rotation about the correct coordinate axis - /// - /// Prepared Quaternion - /// Expected result. - /// Taken from nUnit test data. Don't know how to name data driven tests for xUnit which actually works. - [Theory] - [MemberData(nameof(QuaternionTestDataGenerator.ToAxisAngleTestCases), MemberType = typeof(QuaternionTestDataGenerator))] - public void ToAxisAngle_SingleAxisSetAndAngleIgnored_RotateCorrectAxis(Quaternion cut, Vector3 expectedResult, string testName) - { - //Arrange + Act: Create Quaternion with rotation about X/Y/Z axis - Vector3 resultXYZ; - float dontCare; - cut.ToAxisAngle(out resultXYZ, out dontCare); - - //Assert: Use helper, to check if part of the two correct axis is zero. I just want check the direction - Assert.True(QuaternionTestHelper.VerifyEqualSingleDirection(resultXYZ, expectedResult)); - } - - //TODO: Make also checks with rotation angle } }