001675dced
This simplifies the logging system. This also fixes some lost messages on startup. The simplification is simple. I removed unused functions and moved most things in the .h to the .cpp. I replaced the unnecessary linked list with its contents laid out as three member variables. Anything that went through the linked list now directly accesses the backends. Generic functions are replaced with those for each specific use case and there aren't many. This change increases coupling but we gain back more KISS and encapsulation. With those changes it was easy to make it thread-safe. I just removed the mutex and turned a boolean atomic. I was planning to use this thread-safety in my next PR about stacktraces. It was actually async-signal-safety at first but I ended up using a different approach. Anyway getting rid of the linked list is important for that because have the list of backends constantly changing complicates things.
49 lines
1.5 KiB
C++
49 lines
1.5 KiB
C++
// Copyright 2018 yuzu Emulator Project
|
|
// Licensed under GPLv2 or any later version
|
|
// Refer to the license.txt file included.
|
|
|
|
#ifdef _WIN32
|
|
#include <windows.h>
|
|
|
|
#include <wincon.h>
|
|
#endif
|
|
|
|
#include "common/logging/backend.h"
|
|
#include "yuzu/debugger/console.h"
|
|
#include "yuzu/uisettings.h"
|
|
|
|
namespace Debugger {
|
|
void ToggleConsole() {
|
|
static bool console_shown = false;
|
|
if (console_shown == UISettings::values.show_console.GetValue()) {
|
|
return;
|
|
} else {
|
|
console_shown = UISettings::values.show_console.GetValue();
|
|
}
|
|
|
|
using namespace Common::Log;
|
|
#if defined(_WIN32) && !defined(_DEBUG)
|
|
FILE* temp;
|
|
if (UISettings::values.show_console) {
|
|
if (AllocConsole()) {
|
|
// The first parameter for freopen_s is a out parameter, so we can just ignore it
|
|
freopen_s(&temp, "CONIN$", "r", stdin);
|
|
freopen_s(&temp, "CONOUT$", "w", stdout);
|
|
freopen_s(&temp, "CONOUT$", "w", stderr);
|
|
SetColorConsoleBackendEnabled(true);
|
|
}
|
|
} else {
|
|
if (FreeConsole()) {
|
|
// In order to close the console, we have to also detach the streams on it.
|
|
// Just redirect them to NUL if there is no console window
|
|
SetColorConsoleBackendEnabled(false);
|
|
freopen_s(&temp, "NUL", "r", stdin);
|
|
freopen_s(&temp, "NUL", "w", stdout);
|
|
freopen_s(&temp, "NUL", "w", stderr);
|
|
}
|
|
}
|
|
#else
|
|
SetColorConsoleBackendEnabled(UISettings::values.show_console.GetValue());
|
|
#endif
|
|
}
|
|
} // namespace Debugger
|