million/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

nfp: Correct uninitialized size being used within GetTagInfo()

Browse source 
We were previously the name of the object being initialized within its
own initializer, which results in uninitialized data being read.
This commit is contained in:
Lioncash 2021-02-09 17:41:59 -05:00
parent 0896089092
commit d64ba58759
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/core/hle/service/nfp/nfp.cpp
View file

@ -215,7 +215,7 @@ private:
const auto& amiibo = nfp_interface.GetAmiiboBuffer(); const auto& amiibo = nfp_interface.GetAmiiboBuffer();
const TagInfo tag_info{ const TagInfo tag_info{
.uuid = amiibo.uuid, .uuid = amiibo.uuid,
.uuid_length = static_cast<u8>(tag_info.uuid.size()), .uuid_length = static_cast<u8>(amiibo.uuid.size()),
.padding_1 = {}, .padding_1 = {},
.protocol = 1, // TODO(ogniK): Figure out actual values .protocol = 1, // TODO(ogniK): Figure out actual values
.tag_type = 2, .tag_type = 2,