mctaylors/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

yuzu/main: Resolve precedence bug within CalculateRomFSEntrySize()

Browse source 
Ternary operators have a lower precedence than arithmetic operators, so
what was actually occurring here is "return (out + full) ? x : y" which most
definitely isn't intended, given we calculate out recursively above. We
were essentially doing a lot of work for nothing.
This commit is contained in:
Lioncash 2018-09-25 18:06:35 -04:00
parent cbb146069a
commit f646ca874d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/yuzu/main.cpp
View file

@ -763,7 +763,7 @@ static std::size_t CalculateRomFSEntrySize(const FileSys::VirtualDir& dir, bool
out += 1 + CalculateRomFSEntrySize(subdir, full); out += 1 + CalculateRomFSEntrySize(subdir, full);
} }
return out + full ? dir->GetFiles().size() : 0; return out + (full ? dir->GetFiles().size() : 0);
} }
static bool RomFSRawCopy(QProgressDialog& dialog, const FileSys::VirtualDir& src, static bool RomFSRawCopy(QProgressDialog& dialog, const FileSys::VirtualDir& src,