mctaylors/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

dma_pusher: Store command_list_header by copy

Browse source 
Instead of holding a reference that will get invalidated by
dma_pushbuffer.pop(), hold it as a copy. This doesn't have any
performance cost since CommandListHeader is 8 bytes long.
This commit is contained in:
ReinUsesLisp 2019-03-08 04:06:54 -03:00
parent d26ee6e01e
commit e7ac5a6adf
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/video_core/dma_pusher.cpp
View file

@ -39,7 +39,7 @@ bool DmaPusher::Step() {
} }
const CommandList& command_list{dma_pushbuffer.front()}; const CommandList& command_list{dma_pushbuffer.front()};
const CommandListHeader& command_list_header{command_list[dma_pushbuffer_subindex++]}; const CommandListHeader command_list_header{command_list[dma_pushbuffer_subindex++]};
GPUVAddr dma_get = command_list_header.addr; GPUVAddr dma_get = command_list_header.addr;
GPUVAddr dma_put = dma_get + command_list_header.size * sizeof(u32); GPUVAddr dma_put = dma_get + command_list_header.size * sizeof(u32);
bool non_main = command_list_header.is_non_main; bool non_main = command_list_header.is_non_main;