mctaylors/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

Merge pull request #9024 from liamwhite/async-screenshot

Browse source 
video_core: don't block rendering on screenshots
This commit is contained in:
bunnei 2022-10-12 13:26:32 -07:00 committed by GitHub
commit e158167139
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/video_core/renderer_base.cpp
View file

@ -1,6 +1,8 @@
// SPDX-FileCopyrightText: 2015 Citra Emulator Project // SPDX-FileCopyrightText: 2015 Citra Emulator Project
// SPDX-License-Identifier: GPL-2.0-or-later // SPDX-License-Identifier: GPL-2.0-or-later
#include <thread>
#include "common/logging/log.h" #include "common/logging/log.h"
#include "core/frontend/emu_window.h" #include "core/frontend/emu_window.h"
#include "video_core/renderer_base.h" #include "video_core/renderer_base.h"
@ -35,8 +37,12 @@ void RendererBase::RequestScreenshot(void* data, std::function<void(bool)> callb
LOG_ERROR(Render, "A screenshot is already requested or in progress, ignoring the request"); LOG_ERROR(Render, "A screenshot is already requested or in progress, ignoring the request");
return; return;
} }
auto async_callback{[callback = std::move(callback)](bool invert_y) {
std::thread t{callback, invert_y};
t.detach();
}};
renderer_settings.screenshot_bits = data; renderer_settings.screenshot_bits = data;
renderer_settings.screenshot_complete_callback = std::move(callback); renderer_settings.screenshot_complete_callback = async_callback;
renderer_settings.screenshot_framebuffer_layout = layout; renderer_settings.screenshot_framebuffer_layout = layout;
renderer_settings.screenshot_requested = true; renderer_settings.screenshot_requested = true;
} }