mctaylors/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

gl_rasterizer: Remove num vertex buffers magic number

Browse source
This commit is contained in:
ReinUsesLisp 2020-01-13 17:20:02 -03:00
parent 62437943a7
commit b1498d2c54
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/video_core/renderer_opengl/gl_rasterizer.cpp
View file

@ -54,6 +54,8 @@ MICROPROFILE_DEFINE(OpenGL_PrimitiveAssembly, "OpenGL", "Prim Asmbl", MP_RGB(255
namespace { namespace {
constexpr std::size_t NumSupportedVertexAttributes = 16;
template <typename Engine, typename Entry> template <typename Engine, typename Entry>
Tegra::Texture::FullTextureInfo GetTextureInfo(const Engine& engine, const Entry& entry, Tegra::Texture::FullTextureInfo GetTextureInfo(const Engine& engine, const Entry& entry,
Tegra::Engines::ShaderType shader_type, Tegra::Engines::ShaderType shader_type,
@ -134,7 +136,7 @@ void RasterizerOpenGL::SetupVertexFormat() {
// avoid OpenGL errors. // avoid OpenGL errors.
// TODO(Subv): Analyze the shader to identify which attributes are actually used and don't // TODO(Subv): Analyze the shader to identify which attributes are actually used and don't
// assume every shader uses them all. // assume every shader uses them all.
for (std::size_t index = 0; index < 16; ++index) { for (std::size_t index = 0; index < NumSupportedVertexAttributes; ++index) {
if (!flags[Dirty::VertexFormat0 + index]) { if (!flags[Dirty::VertexFormat0 + index]) {
continue; continue;
} }
@ -207,7 +209,7 @@ void RasterizerOpenGL::SetupVertexInstances() {
flags[Dirty::VertexInstances] = false; flags[Dirty::VertexInstances] = false;
const auto& regs = gpu.regs; const auto& regs = gpu.regs;
for (std::size_t index = 0; index < 16; ++index) { for (std::size_t index = 0; index < NumSupportedVertexAttributes; ++index) {
if (!flags[Dirty::VertexInstance0 + index]) { if (!flags[Dirty::VertexInstance0 + index]) {
continue; continue;
} }