mctaylors/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

nvdrv: Simplify builder declarations

Browse source 
We can just use auto here. If one of these ever happens to not be
derived from nvdevice, then this will cause a compilation error.

We can also move the devices into the collection to get rid of an
unnecessary atomic reference count increment and decrement.
This commit is contained in:
Lioncash 2022-11-28 10:41:19 -05:00
parent 6291eec700
commit ad787b20ca
1 changed files with 18 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
src/core/hle/service/nvdrv/nvdrv.cpp
View file

@ -55,48 +55,40 @@ void InstallInterfaces(SM::ServiceManager& service_manager, NVFlinger::NVFlinger
Module::Module(Core::System& system) Module::Module(Core::System& system)
: container{system.Host1x()}, service_context{system, "nvdrv"}, events_interface{*this} { : container{system.Host1x()}, service_context{system, "nvdrv"}, events_interface{*this} {
builders["/dev/nvhost-as-gpu"] = [this, &system](DeviceFD fd) { builders["/dev/nvhost-as-gpu"] = [this, &system](DeviceFD fd) {
std::shared_ptr<Devices::nvdevice> device = auto device = std::make_shared<Devices::nvhost_as_gpu>(system, *this, container);
std::make_shared<Devices::nvhost_as_gpu>(system, *this, container); return open_files.emplace(fd, std::move(device)).first;
return open_files.emplace(fd, device).first;
}; };
builders["/dev/nvhost-gpu"] = [this, &system](DeviceFD fd) { builders["/dev/nvhost-gpu"] = [this, &system](DeviceFD fd) {
std::shared_ptr<Devices::nvdevice> device = auto device = std::make_shared<Devices::nvhost_gpu>(system, events_interface, container);
std::make_shared<Devices::nvhost_gpu>(system, events_interface, container); return open_files.emplace(fd, std::move(device)).first;
return open_files.emplace(fd, device).first;
}; };
builders["/dev/nvhost-ctrl-gpu"] = [this, &system](DeviceFD fd) { builders["/dev/nvhost-ctrl-gpu"] = [this, &system](DeviceFD fd) {
std::shared_ptr<Devices::nvdevice> device = auto device = std::make_shared<Devices::nvhost_ctrl_gpu>(system, events_interface);
std::make_shared<Devices::nvhost_ctrl_gpu>(system, events_interface); return open_files.emplace(fd, std::move(device)).first;
return open_files.emplace(fd, device).first;
}; };
builders["/dev/nvmap"] = [this, &system](DeviceFD fd) { builders["/dev/nvmap"] = [this, &system](DeviceFD fd) {
std::shared_ptr<Devices::nvdevice> device = auto device = std::make_shared<Devices::nvmap>(system, container);
std::make_shared<Devices::nvmap>(system, container); return open_files.emplace(fd, std::move(device)).first;
return open_files.emplace(fd, device).first;
}; };
builders["/dev/nvdisp_disp0"] = [this, &system](DeviceFD fd) { builders["/dev/nvdisp_disp0"] = [this, &system](DeviceFD fd) {
std::shared_ptr<Devices::nvdevice> device = auto device = std::make_shared<Devices::nvdisp_disp0>(system, container);
std::make_shared<Devices::nvdisp_disp0>(system, container); return open_files.emplace(fd, std::move(device)).first;
return open_files.emplace(fd, device).first;
}; };
builders["/dev/nvhost-ctrl"] = [this, &system](DeviceFD fd) { builders["/dev/nvhost-ctrl"] = [this, &system](DeviceFD fd) {
std::shared_ptr<Devices::nvdevice> device = auto device = std::make_shared<Devices::nvhost_ctrl>(system, events_interface, container);
std::make_shared<Devices::nvhost_ctrl>(system, events_interface, container); return open_files.emplace(fd, std::move(device)).first;
return open_files.emplace(fd, device).first;
}; };
builders["/dev/nvhost-nvdec"] = [this, &system](DeviceFD fd) { builders["/dev/nvhost-nvdec"] = [this, &system](DeviceFD fd) {
std::shared_ptr<Devices::nvdevice> device = auto device = std::make_shared<Devices::nvhost_nvdec>(system, container);
std::make_shared<Devices::nvhost_nvdec>(system, container); return open_files.emplace(fd, std::move(device)).first;
return open_files.emplace(fd, device).first;
}; };
builders["/dev/nvhost-nvjpg"] = [this, &system](DeviceFD fd) { builders["/dev/nvhost-nvjpg"] = [this, &system](DeviceFD fd) {
std::shared_ptr<Devices::nvdevice> device = std::make_shared<Devices::nvhost_nvjpg>(system); auto device = std::make_shared<Devices::nvhost_nvjpg>(system);
return open_files.emplace(fd, device).first; return open_files.emplace(fd, std::move(device)).first;
}; };
builders["/dev/nvhost-vic"] = [this, &system](DeviceFD fd) { builders["/dev/nvhost-vic"] = [this, &system](DeviceFD fd) {
std::shared_ptr<Devices::nvdevice> device = auto device = std::make_shared<Devices::nvhost_vic>(system, container);
std::make_shared<Devices::nvhost_vic>(system, container); return open_files.emplace(fd, std::move(device)).first;
return open_files.emplace(fd, device).first;
}; };
} }