mctaylors/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

Dma_pusher: ASSERT on empty command_list

Browse source 
This is a measure to avoid crashes on command list reading as an empty
command_list is considered a NOP.
This commit is contained in:
Fernando Sahmkow 2019-05-18 20:51:54 -04:00 committed by FernandoS27
parent fb85d5670d
commit 9e98100c94
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/video_core/dma_pusher.cpp
View file

@ -40,6 +40,13 @@ bool DmaPusher::Step() {
} }
const CommandList& command_list{dma_pushbuffer.front()}; const CommandList& command_list{dma_pushbuffer.front()};
ASSERT_OR_EXECUTE(!command_list.empty(), {
// Somehow the command_list is empty, in order to avoid a crash
// We ignore it and assume its size is 0.
dma_pushbuffer.pop();
dma_pushbuffer_subindex = 0;
return true;
});
const CommandListHeader command_list_header{command_list[dma_pushbuffer_subindex++]}; const CommandListHeader command_list_header{command_list[dma_pushbuffer_subindex++]};
GPUVAddr dma_get = command_list_header.addr; GPUVAddr dma_get = command_list_header.addr;
GPUVAddr dma_put = dma_get + command_list_header.size * sizeof(u32); GPUVAddr dma_put = dma_get + command_list_header.size * sizeof(u32);