mctaylors/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

unfold UNREACHABLE implementation for dumb compilers

Browse source 
We relies on UNREACHABLE's noreturn attribute to eliminate parent's "no return value" warning. However, this was wrapped in a `if(!false)` block, which compilers may not unfold to recognize the noreturn nature.
This commit is contained in:
Weiyi Wang 2019-10-05 10:45:01 -04:00 committed by FearlessTobi
parent bedc903c65
commit 9a60d8a430
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/common/assert.h
View file

@ -41,8 +41,8 @@ __declspec(noinline, noreturn)
} \
while (0)
#define UNREACHABLE() ASSERT_MSG(false, "Unreachable code!")
#define UNREACHABLE_MSG(...) ASSERT_MSG(false, __VA_ARGS__)
#define UNREACHABLE() assert_noinline_call([] { LOG_CRITICAL(Debug, "Unreachable code!"); })
#define UNREACHABLE_MSG(...) assert_noinline_call([] { LOG_CRITICAL(Debug, "Unreachable code!\n" __VA_ARGS__); })
#ifdef _DEBUG
#define DEBUG_ASSERT(_a_) ASSERT(_a_)