mctaylors/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

remove constexpr from virtual function

Browse source 
Signed-off-by: arades79 <scravers@protonmail.com>
This commit is contained in:
arades79 2023-02-14 19:14:29 -05:00
parent 880b6e9795
commit 98631b45b6
No known key found for this signature in database
GPG key ID: 19158282E56F0021
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/core/debugger/gdbstub_arch.cpp
View file

@ -41,7 +41,7 @@ static void PutSIMDRegister(std::array<u32, 64>& simd_regs, size_t offset, const
// For sample XML files see the GDB source /gdb/features // For sample XML files see the GDB source /gdb/features
// This XML defines what the registers are for this specific ARM device // This XML defines what the registers are for this specific ARM device
constexpr std::string_view GDBStubA64::GetTargetXML() const { std::string_view GDBStubA64::GetTargetXML() const {
return R"(<?xml version="1.0"?> return R"(<?xml version="1.0"?>
<!DOCTYPE target SYSTEM "gdb-target.dtd"> <!DOCTYPE target SYSTEM "gdb-target.dtd">
<target version="1.0"> <target version="1.0">
@ -267,7 +267,7 @@ u32 GDBStubA64::BreakpointInstruction() const {
return 0xd4200000; return 0xd4200000;
} }
constexpr std::string_view GDBStubA32::GetTargetXML() const { std::string_view GDBStubA32::GetTargetXML() const {
return R"(<?xml version="1.0"?> return R"(<?xml version="1.0"?>
<!DOCTYPE target SYSTEM "gdb-target.dtd"> <!DOCTYPE target SYSTEM "gdb-target.dtd">
<target version="1.0"> <target version="1.0">

6
src/core/debugger/gdbstub_arch.h
View file

@ -16,7 +16,7 @@ namespace Core {
class GDBStubArch { class GDBStubArch {
public: public:
virtual ~GDBStubArch() = default; virtual ~GDBStubArch() = default;
virtual constexpr std::string_view GetTargetXML() const = 0; virtual std::string_view GetTargetXML() const = 0;
virtual std::string RegRead(const Kernel::KThread* thread, size_t id) const = 0; virtual std::string RegRead(const Kernel::KThread* thread, size_t id) const = 0;
virtual void RegWrite(Kernel::KThread* thread, size_t id, std::string_view value) const = 0; virtual void RegWrite(Kernel::KThread* thread, size_t id, std::string_view value) const = 0;
virtual std::string ReadRegisters(const Kernel::KThread* thread) const = 0; virtual std::string ReadRegisters(const Kernel::KThread* thread) const = 0;
@ -27,7 +27,7 @@ public:
class GDBStubA64 final : public GDBStubArch { class GDBStubA64 final : public GDBStubArch {
public: public:
constexpr std::string_view GetTargetXML() const override; std::string_view GetTargetXML() const override;
std::string RegRead(const Kernel::KThread* thread, size_t id) const override; std::string RegRead(const Kernel::KThread* thread, size_t id) const override;
void RegWrite(Kernel::KThread* thread, size_t id, std::string_view value) const override; void RegWrite(Kernel::KThread* thread, size_t id, std::string_view value) const override;
std::string ReadRegisters(const Kernel::KThread* thread) const override; std::string ReadRegisters(const Kernel::KThread* thread) const override;
@ -47,7 +47,7 @@ private:
class GDBStubA32 final : public GDBStubArch { class GDBStubA32 final : public GDBStubArch {
public: public:
constexpr std::string_view GetTargetXML() const override; std::string_view GetTargetXML() const override;
std::string RegRead(const Kernel::KThread* thread, size_t id) const override; std::string RegRead(const Kernel::KThread* thread, size_t id) const override;
void RegWrite(Kernel::KThread* thread, size_t id, std::string_view value) const override; void RegWrite(Kernel::KThread* thread, size_t id, std::string_view value) const override;
std::string ReadRegisters(const Kernel::KThread* thread) const override; std::string ReadRegisters(const Kernel::KThread* thread) const override;