mctaylors/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

core/reporter: Allow moves into SaveToFile()

Browse source 
Taking the json instance as a constant reference, makes all moves into
the parameter non-functional, resulting in copies. Taking it by value
allows moves to function.
This commit is contained in:
Lioncash 2019-07-05 17:40:51 -04:00
parent 2321656dbe
commit 48807e9a24
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/core/reporter.cpp
View file

@ -34,7 +34,7 @@ std::string GetTimestamp() {
using namespace nlohmann;
void SaveToFile(const json& json, const std::string& filename) {
void SaveToFile(json json, const std::string& filename) {
if (!FileUtil::CreateFullPath(filename)) {
LOG_ERROR(Core, "Failed to create path for '{}' to save report!", filename);
return;