mctaylors/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

gl_query_cache: Resolve use-after-move in CachedQuery move assignment operator

Browse source 
Avoids potential invalid junk data from being read.
This commit is contained in:
Lioncash 2020-04-15 22:20:03 -04:00
parent e33196d4e7
commit 3a60f19eaf
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/video_core/renderer_opengl/gl_query_cache.cpp
View file

@ -94,9 +94,9 @@ CachedQuery::CachedQuery(CachedQuery&& rhs) noexcept
: VideoCommon::CachedQueryBase<HostCounter>(std::move(rhs)), cache{rhs.cache}, type{rhs.type} {} : VideoCommon::CachedQueryBase<HostCounter>(std::move(rhs)), cache{rhs.cache}, type{rhs.type} {}
CachedQuery& CachedQuery::operator=(CachedQuery&& rhs) noexcept { CachedQuery& CachedQuery::operator=(CachedQuery&& rhs) noexcept {
VideoCommon::CachedQueryBase<HostCounter>::operator=(std::move(rhs));
cache = rhs.cache; cache = rhs.cache;
type = rhs.type; type = rhs.type;
CachedQueryBase<HostCounter>::operator=(std::move(rhs));
return *this; return *this;
} }