From d1d7ce74d2e175d18c9eb385e202bca98cba08cd Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 15 Oct 2019 18:25:45 -0400 Subject: [PATCH] gl_shader_decompiler: Use std::holds_alternative within GenerateTexture() This only ever queries if the type exists within the variant, but doesn't actually do anything with the return value. We can just use std::holds_alternative for this use case. --- src/video_core/renderer_opengl/gl_shader_decompiler.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp index 3bd3d22443..970cd0c766 100644 --- a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp +++ b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp @@ -1148,7 +1148,7 @@ private: for (const auto& variant : extras) { if (const auto argument = std::get_if(&variant)) { expr += GenerateTextureArgument(*argument); - } else if (std::get_if(&variant)) { + } else if (std::holds_alternative(variant)) { expr += GenerateTextureAoffi(meta->aoffi); } else { UNREACHABLE();