lvella/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

video_core: Refactor command_processor.

Browse source 
Inline the WriteReg helper as it is called ~20k times per frame.
This commit is contained in:
Markus Wick 2018-09-06 17:02:46 +02:00
parent 0cfb0bacb2
commit c1b8cd9058
2 changed files with 42 additions and 44 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/video_core/command_processor.cpp
View file

@ -28,7 +28,12 @@ enum class BufferMethods {
CountBufferMethods = 0x40, CountBufferMethods = 0x40,
}; };
void GPU::WriteReg(u32 method, u32 subchannel, u32 value, u32 remaining_params) { MICROPROFILE_DEFINE(ProcessCommandLists, "GPU", "Execute command buffer", MP_RGB(128, 128, 192));
void GPU::ProcessCommandLists(const std::vector<CommandListHeader>& commands) {
MICROPROFILE_SCOPE(ProcessCommandLists);
auto WriteReg = [this](u32 method, u32 subchannel, u32 value, u32 remaining_params) {
LOG_TRACE(HW_GPU, LOG_TRACE(HW_GPU,
"Processing method {:08X} on subchannel {} value " "Processing method {:08X} on subchannel {} value "
"{:08X} remaining params {}", "{:08X} remaining params {}",
@ -67,12 +72,8 @@ void GPU::WriteReg(u32 method, u32 subchannel, u32 value, u32 remaining_params)
default: default:
UNIMPLEMENTED_MSG("Unimplemented engine"); UNIMPLEMENTED_MSG("Unimplemented engine");
} }
} };
MICROPROFILE_DEFINE(ProcessCommandLists, "GPU", "Execute command buffer", MP_RGB(128, 128, 192));
void GPU::ProcessCommandLists(const std::vector<CommandListHeader>& commands) {
MICROPROFILE_SCOPE(ProcessCommandLists);
for (auto entry : commands) { for (auto entry : commands) {
Tegra::GPUVAddr address = entry.Address(); Tegra::GPUVAddr address = entry.Address();
u32 size = entry.sz; u32 size = entry.sz;

3
src/video_core/gpu.h
View file

@ -132,9 +132,6 @@ public:
const Tegra::MemoryManager& MemoryManager() const; const Tegra::MemoryManager& MemoryManager() const;
private: private:
/// Writes a single register in the engine bound to the specified subchannel
void WriteReg(u32 method, u32 subchannel, u32 value, u32 remaining_params);
std::unique_ptr<Tegra::MemoryManager> memory_manager; std::unique_ptr<Tegra::MemoryManager> memory_manager;
/// Mapping of command subchannels to their bound engine ids. /// Mapping of command subchannels to their bound engine ids.