1
0
Fork 0
forked from suyu/suyu

Merge pull request #8404 from Morph1984/virtual

core/debugger: Define defaulted virtual destructors
This commit is contained in:
liamwhite 2022-06-01 12:30:47 -04:00 committed by GitHub
commit a2f6a2480d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 2 deletions

View file

@ -50,7 +50,7 @@ public:
InitializeServer(port); InitializeServer(port);
} }
~DebuggerImpl() { ~DebuggerImpl() override {
ShutdownServer(); ShutdownServer();
} }

View file

@ -24,6 +24,8 @@ enum class DebuggerAction {
class DebuggerBackend { class DebuggerBackend {
public: public:
virtual ~DebuggerBackend() = default;
/** /**
* Can be invoked from a callback to synchronously wait for more data. * Can be invoked from a callback to synchronously wait for more data.
* Will return as soon as least one byte is received. Reads up to 4096 bytes. * Will return as soon as least one byte is received. Reads up to 4096 bytes.
@ -51,6 +53,8 @@ class DebuggerFrontend {
public: public:
explicit DebuggerFrontend(DebuggerBackend& backend_) : backend{backend_} {} explicit DebuggerFrontend(DebuggerBackend& backend_) : backend{backend_} {}
virtual ~DebuggerFrontend() = default;
/** /**
* Called after the client has successfully connected to the port. * Called after the client has successfully connected to the port.
*/ */

View file

@ -19,7 +19,7 @@ class System;
class GDBStub : public DebuggerFrontend { class GDBStub : public DebuggerFrontend {
public: public:
explicit GDBStub(DebuggerBackend& backend, Core::System& system); explicit GDBStub(DebuggerBackend& backend, Core::System& system);
~GDBStub(); ~GDBStub() override;
void Connected() override; void Connected() override;
void Stopped(Kernel::KThread* thread) override; void Stopped(Kernel::KThread* thread) override;