lvella/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

common/file: Remove [[nodiscard]] from Open()

Browse source 
Since this has a void return value, there's nothing that can actually be
used.
This commit is contained in:
Lioncash 2022-02-01 02:19:16 -05:00
parent 11099dda2e
commit 8f32bab4c9
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/common/fs/file.h
View file

@ -188,8 +188,7 @@ public:
#ifdef _WIN32 #ifdef _WIN32
template <typename Path> template <typename Path>
[[nodiscard]] void Open(const Path& path, FileAccessMode mode, void Open(const Path& path, FileAccessMode mode, FileType type = FileType::BinaryFile,
FileType type = FileType::BinaryFile,
FileShareFlag flag = FileShareFlag::ShareReadOnly) { FileShareFlag flag = FileShareFlag::ShareReadOnly) {
using ValueType = typename Path::value_type; using ValueType = typename Path::value_type;
if constexpr (IsChar<ValueType>) { if constexpr (IsChar<ValueType>) {