lvella/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

buffer_block: Mark interface as nodiscard where applicable

Browse source 
Prevents logic errors from occurring from unused values.
This commit is contained in:
Lioncash 2020-12-07 01:53:37 -05:00
parent 3954f14c6d
commit 5d2f18fbcd
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/video_core/buffer_cache/buffer_block.h
View file

@ -10,23 +10,23 @@ namespace VideoCommon {
class BufferBlock { class BufferBlock {
public: public:
bool Overlaps(VAddr start, VAddr end) const { [[nodiscard]] bool Overlaps(VAddr start, VAddr end) const {
return (cpu_addr < end) && (cpu_addr_end > start); return (cpu_addr < end) && (cpu_addr_end > start);
} }
bool IsInside(VAddr other_start, VAddr other_end) const { [[nodiscard]] bool IsInside(VAddr other_start, VAddr other_end) const {
return cpu_addr <= other_start && other_end <= cpu_addr_end; return cpu_addr <= other_start && other_end <= cpu_addr_end;
} }
std::size_t Offset(VAddr in_addr) const { [[nodiscard]] std::size_t Offset(VAddr in_addr) const {
return static_cast<std::size_t>(in_addr - cpu_addr); return static_cast<std::size_t>(in_addr - cpu_addr);
} }
VAddr CpuAddr() const { [[nodiscard]] VAddr CpuAddr() const {
return cpu_addr; return cpu_addr;
} }
VAddr CpuAddrEnd() const { [[nodiscard]] VAddr CpuAddrEnd() const {
return cpu_addr_end; return cpu_addr_end;
} }
@ -35,11 +35,11 @@ public:
cpu_addr_end = new_addr + size; cpu_addr_end = new_addr + size;
} }
std::size_t Size() const { [[nodiscard]] std::size_t Size() const {
return size; return size;
} }
u64 Epoch() const { [[nodiscard]] u64 Epoch() const {
return epoch; return epoch;
} }