lvella/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

configure_graphics: Prevent stack-use-after-scope

Browse source 
Address Sanitizer reports stack-use-after-scope on line 231
`vulkan_devices.push_back(QString::fromStdString(name));`. Instead of
using a pointer, copy the string into a std::string and use that,
instead.
This commit is contained in:
lat9nq 2021-04-04 15:02:35 -04:00
parent 69b2dbdffd
commit 33ed02a239
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/yuzu/configuration/configure_graphics.cpp
View file

@ -227,7 +227,7 @@ void ConfigureGraphics::RetrieveVulkanDevices() try {
vulkan_devices.clear(); vulkan_devices.clear();
vulkan_devices.reserve(physical_devices.size()); vulkan_devices.reserve(physical_devices.size());
for (const VkPhysicalDevice device : physical_devices) { for (const VkPhysicalDevice device : physical_devices) {
const char* const name = vk::PhysicalDevice(device, dld).GetProperties().deviceName; const std::string name = vk::PhysicalDevice(device, dld).GetProperties().deviceName;
vulkan_devices.push_back(QString::fromStdString(name)); vulkan_devices.push_back(QString::fromStdString(name));
} }