lvella/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

callstack: Remove unnecessary disassembler instantiation

Browse source 
Decode is a static function. There's no need to allocate a disassembler instance.
This commit is contained in:
Lioncash 2015-03-30 11:22:52 -04:00
parent c4767f3bb2
commit 0520a3b178
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/citra_qt/debugger/callstack.cpp
View file

@ -27,7 +27,6 @@ CallstackWidget::CallstackWidget(QWidget* parent): QDockWidget(parent)
void CallstackWidget::OnDebugModeEntered() void CallstackWidget::OnDebugModeEntered()
{ {
ARM_Disasm* disasm = new ARM_Disasm();
ARM_Interface* app_core = Core::g_app_core; ARM_Interface* app_core = Core::g_app_core;
u32 sp = app_core->GetReg(13); //stack pointer u32 sp = app_core->GetReg(13); //stack pointer
@ -46,7 +45,7 @@ void CallstackWidget::OnDebugModeEntered()
/* TODO (mattvail) clean me, move to debugger interface */ /* TODO (mattvail) clean me, move to debugger interface */
u32 insn = Memory::Read32(call_addr); u32 insn = Memory::Read32(call_addr);
if (disasm->Decode(insn) == OP_BL) if (ARM_Disasm::Decode(insn) == OP_BL)
{ {
std::string name; std::string name;
// ripped from disasm // ripped from disasm