GPU: Make the GPU virtual memory manager use 16 page bits and 10 page table bits.

Also removed some dead code and added memory map consistency asserts.

src/video_core/memory_manager.cpp

@@ -2,6 +2,7 @@
 // Licensed under GPLv2 or any later version
 // Refer to the license.txt file included.
 
+#include "common/alignment.h"
 #include "common/assert.h"
 #include "video_core/memory_manager.h"
 
@@ -11,7 +12,8 @@ PAddr MemoryManager::AllocateSpace(u64 size, u64 align) {
     boost::optional<PAddr> paddr = FindFreeBlock(size, align);
     ASSERT(paddr);
 
-    for (u64 offset = 0; offset < size; offset += Memory::PAGE_SIZE) {
+    for (u64 offset = 0; offset < size; offset += PAGE_SIZE) {
+        ASSERT(PageSlot(*paddr + offset) == static_cast<u64>(PageStatus::Unmapped));
         PageSlot(*paddr + offset) = static_cast<u64>(PageStatus::Allocated);
     }
 
@@ -19,13 +21,8 @@ PAddr MemoryManager::AllocateSpace(u64 size, u64 align) {
 }
 
 PAddr MemoryManager::AllocateSpace(PAddr paddr, u64 size, u64 align) {
-    for (u64 offset = 0; offset < size; offset += Memory::PAGE_SIZE) {
+    for (u64 offset = 0; offset < size; offset += PAGE_SIZE) {
-        if (IsPageMapped(paddr + offset)) {
+        ASSERT(PageSlot(paddr + offset) == static_cast<u64>(PageStatus::Unmapped));
-            return AllocateSpace(size, align);
-        }
-    }
-
-    for (u64 offset = 0; offset < size; offset += Memory::PAGE_SIZE) {
         PageSlot(paddr + offset) = static_cast<u64>(PageStatus::Allocated);
     }
 
@@ -33,12 +30,11 @@ PAddr MemoryManager::AllocateSpace(PAddr paddr, u64 size, u64 align) {
 }
 
 PAddr MemoryManager::MapBufferEx(VAddr vaddr, u64 size) {
-    vaddr &= ~Memory::PAGE_MASK;
+    boost::optional<PAddr> paddr = FindFreeBlock(size, PAGE_SIZE);
-
-    boost::optional<PAddr> paddr = FindFreeBlock(size);
     ASSERT(paddr);
 
-    for (u64 offset = 0; offset < size; offset += Memory::PAGE_SIZE) {
+    for (u64 offset = 0; offset < size; offset += PAGE_SIZE) {
+        ASSERT(PageSlot(*paddr + offset) == static_cast<u64>(PageStatus::Unmapped));
         PageSlot(*paddr + offset) = vaddr + offset;
     }
 
@@ -46,16 +42,10 @@ PAddr MemoryManager::MapBufferEx(VAddr vaddr, u64 size) {
 }
 
 PAddr MemoryManager::MapBufferEx(VAddr vaddr, PAddr paddr, u64 size) {
-    vaddr &= ~Memory::PAGE_MASK;
+    ASSERT((paddr & PAGE_MASK) == 0);
-    paddr &= ~Memory::PAGE_MASK;
 
-    for (u64 offset = 0; offset < size; offset += Memory::PAGE_SIZE) {
+    for (u64 offset = 0; offset < size; offset += PAGE_SIZE) {
-        if (PageSlot(paddr + offset) != static_cast<u64>(PageStatus::Allocated)) {
+        ASSERT(PageSlot(paddr + offset) == static_cast<u64>(PageStatus::Allocated));
-            return MapBufferEx(vaddr, size);
-        }
-    }
-
-    for (u64 offset = 0; offset < size; offset += Memory::PAGE_SIZE) {
         PageSlot(paddr + offset) = vaddr + offset;
     }
 
@@ -63,23 +53,20 @@ PAddr MemoryManager::MapBufferEx(VAddr vaddr, PAddr paddr, u64 size) {
 }
 
 boost::optional<PAddr> MemoryManager::FindFreeBlock(u64 size, u64 align) {
-    PAddr paddr{};
+    PAddr paddr = 0;
-    u64 free_space{};
+    u64 free_space = 0;
-    align = (align + Memory::PAGE_MASK) & ~Memory::PAGE_MASK;
+    align = (align + PAGE_MASK) & ~PAGE_MASK;
 
     while (paddr + free_space < MAX_ADDRESS) {
         if (!IsPageMapped(paddr + free_space)) {
-            free_space += Memory::PAGE_SIZE;
+            free_space += PAGE_SIZE;
             if (free_space >= size) {
                 return paddr;
             }
         } else {
-            paddr += free_space + Memory::PAGE_SIZE;
+            paddr += free_space + PAGE_SIZE;
             free_space = 0;
-            const u64 remainder{paddr % align};
+            paddr = Common::AlignUp(paddr, align);
-            if (!remainder) {
-                paddr = (paddr - remainder) + align;
-            }
         }
     }
 
@@ -89,7 +76,7 @@ boost::optional<PAddr> MemoryManager::FindFreeBlock(u64 size, u64 align) {
 VAddr MemoryManager::PhysicalToVirtualAddress(PAddr paddr) {
     VAddr base_addr = PageSlot(paddr);
     ASSERT(base_addr != static_cast<u64>(PageStatus::Unmapped));
-    return base_addr + (paddr & Memory::PAGE_MASK);
+    return base_addr + (paddr & PAGE_MASK);
 }
 
 bool MemoryManager::IsPageMapped(PAddr paddr) {
@@ -97,14 +84,14 @@ bool MemoryManager::IsPageMapped(PAddr paddr) {
 }
 
 VAddr& MemoryManager::PageSlot(PAddr paddr) {
-    auto& block = page_table[(paddr >> (Memory::PAGE_BITS + PAGE_TABLE_BITS)) & PAGE_TABLE_MASK];
+    auto& block = page_table[(paddr >> (PAGE_BITS + PAGE_TABLE_BITS)) & PAGE_TABLE_MASK];
     if (!block) {
         block = std::make_unique<PageBlock>();
         for (unsigned index = 0; index < PAGE_BLOCK_SIZE; index++) {
             (*block)[index] = static_cast<u64>(PageStatus::Unmapped);
         }
     }
-    return (*block)[(paddr >> Memory::PAGE_BITS) & PAGE_BLOCK_MASK];
+    return (*block)[(paddr >> PAGE_BITS) & PAGE_BLOCK_MASK];
 }
 
 } // namespace Tegra

src/video_core/memory_manager.h

@@ -24,6 +24,10 @@ public:
     PAddr MapBufferEx(VAddr vaddr, PAddr paddr, u64 size);
     VAddr PhysicalToVirtualAddress(PAddr paddr);
 
+    static constexpr u64 PAGE_BITS = 16;
+    static constexpr u64 PAGE_SIZE = 1 << PAGE_BITS;
+    static constexpr u64 PAGE_MASK = PAGE_SIZE - 1;
+
 private:
     boost::optional<PAddr> FindFreeBlock(u64 size, u64 align = 1);
     bool IsPageMapped(PAddr paddr);
@@ -35,7 +39,7 @@ private:
     };
 
     static constexpr u64 MAX_ADDRESS{0x10000000000ULL};
-    static constexpr u64 PAGE_TABLE_BITS{14};
+    static constexpr u64 PAGE_TABLE_BITS{10};
     static constexpr u64 PAGE_TABLE_SIZE{1 << PAGE_TABLE_BITS};
     static constexpr u64 PAGE_TABLE_MASK{PAGE_TABLE_SIZE - 1};
     static constexpr u64 PAGE_BLOCK_BITS{14};