hwpplayer1/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

Merge pull request #335 from bunnei/delete-file

Browse source 
fsp_srv: Implement DeleteFile.
This commit is contained in:
bunnei 2018-04-15 15:13:02 -04:00 committed by GitHub
commit b8825fbf10
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 27 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/core/file_sys/disk_filesystem.cpp
View file

@ -57,10 +57,14 @@ ResultVal<std::unique_ptr<StorageBackend>> Disk_FileSystem::OpenFile(const std::
std::make_unique<Disk_Storage>(std::move(file))); std::make_unique<Disk_Storage>(std::move(file)));
} }
ResultCode Disk_FileSystem::DeleteFile(const Path& path) const { ResultCode Disk_FileSystem::DeleteFile(const std::string& path) const {
LOG_WARNING(Service_FS, "(STUBBED) called"); if (!FileUtil::Exists(path)) {
// TODO(bunnei): Use correct error code return ERROR_PATH_NOT_FOUND;
return ResultCode(-1); }
FileUtil::Delete(path);
return RESULT_SUCCESS;
} }
ResultCode Disk_FileSystem::RenameFile(const Path& src_path, const Path& dest_path) const { ResultCode Disk_FileSystem::RenameFile(const Path& src_path, const Path& dest_path) const {

2
src/core/file_sys/disk_filesystem.h
View file

@ -25,7 +25,7 @@ public:
ResultVal<std::unique_ptr<StorageBackend>> OpenFile(const std::string& path, ResultVal<std::unique_ptr<StorageBackend>> OpenFile(const std::string& path,
Mode mode) const override; Mode mode) const override;
ResultCode DeleteFile(const Path& path) const override; ResultCode DeleteFile(const std::string& path) const override;
ResultCode RenameFile(const Path& src_path, const Path& dest_path) const override; ResultCode RenameFile(const Path& src_path, const Path& dest_path) const override;
ResultCode DeleteDirectory(const Path& path) const override; ResultCode DeleteDirectory(const Path& path) const override;
ResultCode DeleteDirectoryRecursively(const Path& path) const override; ResultCode DeleteDirectoryRecursively(const Path& path) const override;

2
src/core/file_sys/filesystem.h
View file

@ -97,7 +97,7 @@ public:
* @param path Path relative to the archive * @param path Path relative to the archive
* @return Result of the operation * @return Result of the operation
*/ */
virtual ResultCode DeleteFile(const Path& path) const = 0; virtual ResultCode DeleteFile(const std::string& path) const = 0;
/** /**
* Create a directory specified by its path * Create a directory specified by its path

2
src/core/file_sys/romfs_filesystem.cpp
View file

@ -20,7 +20,7 @@ ResultVal<std::unique_ptr<StorageBackend>> RomFS_FileSystem::OpenFile(const std:
std::make_unique<RomFS_Storage>(romfs_file, data_offset, data_size)); std::make_unique<RomFS_Storage>(romfs_file, data_offset, data_size));
} }
ResultCode RomFS_FileSystem::DeleteFile(const Path& path) const { ResultCode RomFS_FileSystem::DeleteFile(const std::string& path) const {
LOG_CRITICAL(Service_FS, "Attempted to delete a file from an ROMFS archive (%s).", LOG_CRITICAL(Service_FS, "Attempted to delete a file from an ROMFS archive (%s).",
GetName().c_str()); GetName().c_str());
// TODO(bunnei): Use correct error code // TODO(bunnei): Use correct error code

2
src/core/file_sys/romfs_filesystem.h
View file

@ -31,7 +31,7 @@ public:
ResultVal<std::unique_ptr<StorageBackend>> OpenFile(const std::string& path, ResultVal<std::unique_ptr<StorageBackend>> OpenFile(const std::string& path,
Mode mode) const override; Mode mode) const override;
ResultCode DeleteFile(const Path& path) const override; ResultCode DeleteFile(const std::string& path) const override;
ResultCode RenameFile(const Path& src_path, const Path& dest_path) const override; ResultCode RenameFile(const Path& src_path, const Path& dest_path) const override;
ResultCode DeleteDirectory(const Path& path) const override; ResultCode DeleteDirectory(const Path& path) const override;
ResultCode DeleteDirectoryRecursively(const Path& path) const override; ResultCode DeleteDirectoryRecursively(const Path& path) const override;

16
src/core/hle/service/filesystem/fsp_srv.cpp
View file

@ -236,7 +236,7 @@ public:
: ServiceFramework("IFileSystem"), backend(std::move(backend)) { : ServiceFramework("IFileSystem"), backend(std::move(backend)) {
static const FunctionInfo functions[] = { static const FunctionInfo functions[] = {
{0, &IFileSystem::CreateFile, "CreateFile"}, {0, &IFileSystem::CreateFile, "CreateFile"},
{1, nullptr, "DeleteFile"}, {1, &IFileSystem::DeleteFile, "DeleteFile"},
{2, &IFileSystem::CreateDirectory, "CreateDirectory"}, {2, &IFileSystem::CreateDirectory, "CreateDirectory"},
{3, nullptr, "DeleteDirectory"}, {3, nullptr, "DeleteDirectory"},
{4, nullptr, "DeleteDirectoryRecursively"}, {4, nullptr, "DeleteDirectoryRecursively"},
@ -273,6 +273,20 @@ public:
rb.Push(backend->CreateFile(name, size)); rb.Push(backend->CreateFile(name, size));
} }
void DeleteFile(Kernel::HLERequestContext& ctx) {
IPC::RequestParser rp{ctx};
auto file_buffer = ctx.ReadBuffer();
auto end = std::find(file_buffer.begin(), file_buffer.end(), '\0');
std::string name(file_buffer.begin(), end);
LOG_DEBUG(Service_FS, "called file %s", name.c_str());
IPC::ResponseBuilder rb{ctx, 2};
rb.Push(backend->DeleteFile(name));
}
void CreateDirectory(Kernel::HLERequestContext& ctx) { void CreateDirectory(Kernel::HLERequestContext& ctx) {
IPC::RequestParser rp{ctx}; IPC::RequestParser rp{ctx};