1
0
Fork 0
forked from suyu/suyu
suyu/src/yuzu
Lioncash 2b2dc00bfd qt/main: Better file-existence checking within OnMenuRecentFile() and UpdateUITheme()
In OnMenuRecentFile() we don't need to construct a QFileInfo instance
just to check if a file exists, we can just use the static member
function to do that (which Qt's documentation also notes as quicker than
constructing an instance).

In UpdateUITheme(), we just want to try and open the file and check the
success of that operation. Technically speaking, between the existence
check and the open call, the file can be deleted or moved, but still
appear to succeed in code. i.e.

1. Existence check -> Returns true
2. File is moved/deleted
3. Open is called, the return value of which isn't checked
4. Nonsense behavior

This way we combine the existence check and the open into one.
2018-08-06 14:17:13 -04:00
..
configuration Merge pull request #849 from DarkLordZach/xci 2018-08-04 14:33:11 -04:00
debugger Merge pull request #894 from lioncash/object 2018-08-03 00:28:43 -04:00
util qt: Migrate to Qt 5 signal/slot connection syntax where applicable 2018-01-18 20:09:40 -05:00
about_dialog.cpp Port #3837 from Citra: "Add build date in about dialog" 2018-07-29 14:27:19 +02:00
about_dialog.h Implement "About" dialog 2018-01-14 19:15:45 +01:00
aboutdialog.ui Merge pull request #859 from FearlessTobi/port-3837 2018-07-30 10:11:43 -07:00
bootmanager.cpp OpenGL: Use MakeCurrent/DoneCurrent for multithreaded rendering. 2018-07-14 02:50:35 -04:00
bootmanager.h bootmanager: Minor tidiness/correctness changes 2018-01-17 18:35:02 -05:00
CMakeLists.txt audio_core: Add configuration settings. 2018-07-31 22:38:42 -04:00
game_list.cpp Remove files that are not used 2018-08-01 00:16:54 -04:00
game_list.h game_list: Make ContainsAllWords an internally linked non-member function 2018-07-18 16:52:14 -04:00
game_list_p.h clang-format 2018-01-16 18:05:21 +00:00
hotkeys.cpp hotkeys: Add missing <QTreeWidgetItem> include 2018-01-17 20:00:25 -05:00
hotkeys.h Massive removal of unused modules 2018-01-12 19:11:03 -07:00
hotkeys.ui Massive removal of unused modules 2018-01-12 19:11:03 -07:00
Info.plist macOS: Update Info.plist 2018-01-13 23:11:51 +00:00
main.cpp qt/main: Better file-existence checking within OnMenuRecentFile() and UpdateUITheme() 2018-08-06 14:17:13 -04:00
main.h Add 'Load Folder' menu option 2018-06-14 12:27:29 -04:00
main.ui Add 'Load Folder' menu option 2018-06-14 12:27:29 -04:00
ui_settings.cpp Massive removal of unused modules 2018-01-12 19:11:03 -07:00
ui_settings.h Add configurable logging backends 2018-07-02 21:45:47 -04:00
yuzu.rc Removing unused settings and yuzu rebranding 2018-01-12 19:11:05 -07:00