flodavid/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

svc: Avoid incorrect fast yield condition

Browse source
This commit is contained in:
Zach Hilman 2018-12-04 22:11:32 -05:00
parent ddf5903cd9
commit e6f7825a24
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/core/hle/kernel/svc.cpp
View file

@ -960,11 +960,6 @@ static void ExitThread() {
static void SleepThread(s64 nanoseconds) { static void SleepThread(s64 nanoseconds) {
LOG_TRACE(Kernel_SVC, "called nanoseconds={}", nanoseconds); LOG_TRACE(Kernel_SVC, "called nanoseconds={}", nanoseconds);
// Don't attempt to yield execution if there are no available threads to run,
// this way we avoid a useless reschedule to the idle thread.
if (nanoseconds <= 0 && !Core::System::GetInstance().CurrentScheduler().HaveReadyThreads())
return;
enum class SleepType : s64 { enum class SleepType : s64 {
YieldWithoutLoadBalancing = 0, YieldWithoutLoadBalancing = 0,
YieldWithLoadBalancing = -1, YieldWithLoadBalancing = -1,
@ -995,7 +990,7 @@ static void SleepThread(s64 nanoseconds) {
} }
// Reschedule all CPU cores // Reschedule all CPU cores
for (std::size_t i = 0; i < 4; ++i) for (std::size_t i = 0; i < Core::NUM_CPU_CORES; ++i)
Core::System::GetInstance().CpuCore(i).PrepareReschedule(); Core::System::GetInstance().CpuCore(i).PrepareReschedule();
} }