flodavid/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

More missed suggestions

Browse source
This commit is contained in:
boludoz 2023-10-16 16:11:24 -03:00
parent 89d3e81be8
commit d759de9f96
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/yuzu/main.cpp
View file

@ -2995,12 +2995,10 @@ bool GMainWindow::CreateShortcutLink(const std::filesystem::path& shortcut_path,
// Messages in pre-defined message boxes for less code spaghetti // Messages in pre-defined message boxes for less code spaghetti
bool GMainWindow::CreateShortcutMessagesGUI(QWidget* parent, int imsg, const QString& game_title) { bool GMainWindow::CreateShortcutMessagesGUI(QWidget* parent, int imsg, const QString& game_title) {
QMessageBox::StandardButtons buttons; QMessageBox::StandardButtons buttons;
std::string_view game_title_sv = game_title.toStdString();
int result = 0; int result = 0;
switch (imsg) { switch (imsg) {
case GMainWindow::CREATE_SHORTCUT_MSGBOX_FULLSCREEN_YES: case GMainWindow::CREATE_SHORTCUT_MSGBOX_FULLSCREEN_YES:
buttons = QMessageBox::Yes | QMessageBox::No; buttons = QMessageBox::Yes | QMessageBox::No;
@ -3009,12 +3007,11 @@ bool GMainWindow::CreateShortcutMessagesGUI(QWidget* parent, int imsg, const QSt
tr("Do you want to launch the game in fullscreen?"), buttons); tr("Do you want to launch the game in fullscreen?"), buttons);
LOG_INFO(Frontend, "Shortcut will launch in fullscreen"); LOG_INFO(Frontend, "Shortcut will launch in fullscreen");
return (result == QMessageBox::No) ? false : true; return result == QMessageBox::Yes;
case GMainWindow::CREATE_SHORTCUT_MSGBOX_SUCCESS: case GMainWindow::CREATE_SHORTCUT_MSGBOX_SUCCESS:
QMessageBox::information(parent, tr("Create Shortcut"), QMessageBox::information(parent, tr("Create Shortcut"),
tr("Successfully created a shortcut to %1").arg(game_title)); tr("Successfully created a shortcut to %1").arg(game_title));
LOG_INFO(Frontend, "Successfully created a shortcut to {}", game_title_sv);
return true; return true;
case GMainWindow::CREATE_SHORTCUT_MSGBOX_APPVOLATILE_WARNING: case GMainWindow::CREATE_SHORTCUT_MSGBOX_APPVOLATILE_WARNING:
@ -3024,7 +3021,7 @@ bool GMainWindow::CreateShortcutMessagesGUI(QWidget* parent, int imsg, const QSt
tr("This will create a shortcut to the current AppImage. This may " tr("This will create a shortcut to the current AppImage. This may "
"not work well if you update. Continue?"), "not work well if you update. Continue?"),
buttons); buttons);
return (result == QMessageBox::StandardButton::Cancel) ? true : false; return result == QMessageBox::StandardButton::Ok;
case GMainWindow::CREATE_SHORTCUT_MSGBOX_ADMIN: case GMainWindow::CREATE_SHORTCUT_MSGBOX_ADMIN:
buttons = QMessageBox::Ok; buttons = QMessageBox::Ok;
QMessageBox::critical(parent, tr("Create Shortcut"), QMessageBox::critical(parent, tr("Create Shortcut"),
@ -3036,7 +3033,6 @@ bool GMainWindow::CreateShortcutMessagesGUI(QWidget* parent, int imsg, const QSt
buttons = QMessageBox::Ok; buttons = QMessageBox::Ok;
QMessageBox::critical(parent, tr("Create Shortcut"), QMessageBox::critical(parent, tr("Create Shortcut"),
tr("Failed to create a shortcut to %1").arg(game_title), buttons); tr("Failed to create a shortcut to %1").arg(game_title), buttons);
LOG_ERROR(Frontend, "Failed to create a shortcut to {}", game_title_sv);
return true; return true;
} }