flodavid/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

audio_core: Convert LOG_CRITICAL + UNREACHABLE over to UNIMPLEMENTED/UNIMPLEMENTED_MSG

Browse source 
These two macros being used in tandem were used prior to the
introduction of UNIMPLEMENTED and UNIMPLEMENTED_MSG. This provides
equivalent behavior, just with less typing/reading involved.
This commit is contained in:
Lioncash 2018-12-28 14:04:44 -05:00
parent e84e4fd3f8
commit a73c7c73eb
3 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/audio_core/audio_out.cpp
View file

@ -22,8 +22,7 @@ static Stream::Format ChannelsToStreamFormat(u32 num_channels) {
return Stream::Format::Multi51Channel16; return Stream::Format::Multi51Channel16;
} }
LOG_CRITICAL(Audio, "Unimplemented num_channels={}", num_channels); UNIMPLEMENTED_MSG("Unimplemented num_channels={}", num_channels);
UNREACHABLE();
return {}; return {};
} }

6
src/audio_core/audio_renderer.cpp
View file

@ -260,8 +260,7 @@ void AudioRenderer::VoiceState::RefreshBuffer() {
break; break;
} }
default: default:
LOG_CRITICAL(Audio, "Unimplemented sample_format={}", info.sample_format); UNIMPLEMENTED_MSG("Unimplemented sample_format={}", info.sample_format);
UNREACHABLE();
break; break;
} }
@ -280,8 +279,7 @@ void AudioRenderer::VoiceState::RefreshBuffer() {
break; break;
} }
default: default:
LOG_CRITICAL(Audio, "Unimplemented channel_count={}", info.channel_count); UNIMPLEMENTED_MSG("Unimplemented channel_count={}", info.channel_count);
UNREACHABLE();
break; break;
} }

7
src/audio_core/stream.cpp
View file

@ -28,8 +28,7 @@ u32 Stream::GetNumChannels() const {
case Format::Multi51Channel16: case Format::Multi51Channel16:
return 6; return 6;
} }
LOG_CRITICAL(Audio, "Unimplemented format={}", static_cast<u32>(format)); UNIMPLEMENTED_MSG("Unimplemented format={}", static_cast<u32>(format));
UNREACHABLE();
return {}; return {};
} }
@ -49,7 +48,7 @@ void Stream::Play() {
void Stream::Stop() { void Stream::Stop() {
state = State::Stopped; state = State::Stopped;
ASSERT_MSG(false, "Unimplemented"); UNIMPLEMENTED();
} }
Stream::State Stream::GetState() const { Stream::State Stream::GetState() const {
@ -120,7 +119,7 @@ bool Stream::QueueBuffer(BufferPtr&& buffer) {
} }
bool Stream::ContainsBuffer(Buffer::Tag tag) const { bool Stream::ContainsBuffer(Buffer::Tag tag) const {
ASSERT_MSG(false, "Unimplemented"); UNIMPLEMENTED();
return {}; return {};
} }