flodavid/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

android: Separate emulation states from emulation mutex

Browse source 
Emulation states are repeatedly checked by input and performance stats. During startup and shutdown, this could lead to a long halt on the UI thread because the call to IsRunning will be waiting on the emulation mutex to be unlocked. Using atomics should replace the existing functionality without causing problems.
This commit is contained in:
Charles Lombardo 2023-08-27 22:04:04 -04:00
parent b0a96d5216
commit 5445e974e0
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/android/app/src/main/jni/native.cpp
View file

@ -203,12 +203,10 @@ public:
} }
bool IsRunning() const { bool IsRunning() const {
std::scoped_lock lock(m_mutex);
return m_is_running; return m_is_running;
} }
bool IsPaused() const { bool IsPaused() const {
std::scoped_lock lock(m_mutex);
return m_is_running && m_is_paused; return m_is_running && m_is_paused;
} }
@ -544,8 +542,8 @@ private:
Core::PerfStatsResults m_perf_stats{}; Core::PerfStatsResults m_perf_stats{};
std::shared_ptr<FileSys::VfsFilesystem> m_vfs; std::shared_ptr<FileSys::VfsFilesystem> m_vfs;
Core::SystemResultStatus m_load_result{Core::SystemResultStatus::ErrorNotInitialized}; Core::SystemResultStatus m_load_result{Core::SystemResultStatus::ErrorNotInitialized};
bool m_is_running{}; std::atomic<bool> m_is_running = false;
bool m_is_paused{}; std::atomic<bool> m_is_paused = false;
SoftwareKeyboard::AndroidKeyboard* m_software_keyboard{}; SoftwareKeyboard::AndroidKeyboard* m_software_keyboard{};
std::unique_ptr<Service::Account::ProfileManager> m_profile_manager; std::unique_ptr<Service::Account::ProfileManager> m_profile_manager;
std::unique_ptr<FileSys::ManualContentProvider> m_manual_provider; std::unique_ptr<FileSys::ManualContentProvider> m_manual_provider;