flodavid/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

configure_audio: Add disambiguation comment for the volume percentage string

Browse source 
Disambiguates what the string represents to help translators more easily
understand what it is that they're translating. While we're at it, we
can move the code to its own function, so that we don't need to specify
the same string twice.
This commit is contained in:
Lioncash 2018-10-02 19:45:09 -04:00
parent bc679c9b8c
commit 226dc914b3
2 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/yuzu/configuration/configure_audio.cpp
View file

@ -21,9 +21,8 @@ ConfigureAudio::ConfigureAudio(QWidget* parent)
ui->output_sink_combo_box->addItem(sink_detail.id); ui->output_sink_combo_box->addItem(sink_detail.id);
} }
connect(ui->volume_slider, &QSlider::valueChanged, [this] { connect(ui->volume_slider, &QSlider::valueChanged, this,
ui->volume_indicator->setText(tr("%1 %").arg(ui->volume_slider->sliderPosition())); &ConfigureAudio::setVolumeIndicatorText);
});
this->setConfiguration(); this->setConfiguration();
connect(ui->output_sink_combo_box, connect(ui->output_sink_combo_box,
@ -62,7 +61,11 @@ void ConfigureAudio::setConfiguration() {
ui->audio_device_combo_box->setCurrentIndex(new_device_index); ui->audio_device_combo_box->setCurrentIndex(new_device_index);
ui->volume_slider->setValue(Settings::values.volume * ui->volume_slider->maximum()); ui->volume_slider->setValue(Settings::values.volume * ui->volume_slider->maximum());
ui->volume_indicator->setText(tr("%1 %").arg(ui->volume_slider->sliderPosition())); setVolumeIndicatorText(ui->volume_slider->sliderPosition());
}
void ConfigureAudio::setVolumeIndicatorText(int percentage) {
ui->volume_indicator->setText(tr("%1%", "Volume percentage (e.g. 50%)").arg(percentage));
} }
void ConfigureAudio::applyConfiguration() { void ConfigureAudio::applyConfiguration() {

1
src/yuzu/configuration/configure_audio.h
View file

@ -26,6 +26,7 @@ public slots:
private: private:
void setConfiguration(); void setConfiguration();
void setVolumeIndicatorText(int percentage);
std::unique_ptr<Ui::ConfigureAudio> ui; std::unique_ptr<Ui::ConfigureAudio> ui;
}; };