flodavid/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

core/frontend/emu_window: Make GraphicsContext's destructor virtual

Browse source 
This class is used in a polymorphic context, so destruction of the
context will lead to undefined behavior if the destructor isn't virtual.
This commit is contained in:
Lioncash 2019-05-04 01:47:16 -04:00
parent 1f72bb733f
commit 1230a0e7ce
No known key found for this signature in database
GPG key ID: 4E3C3CC1031BA9C7
2 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/core/frontend/emu_window.cpp
View file

@ -10,6 +10,8 @@
namespace Core::Frontend { namespace Core::Frontend {
GraphicsContext::~GraphicsContext() = default;
class EmuWindow::TouchState : public Input::Factory<Input::TouchDevice>, class EmuWindow::TouchState : public Input::Factory<Input::TouchDevice>,
public std::enable_shared_from_this<TouchState> { public std::enable_shared_from_this<TouchState> {
public: public:

2
src/core/frontend/emu_window.h
View file

@ -19,6 +19,8 @@ namespace Core::Frontend {
*/ */
class GraphicsContext { class GraphicsContext {
public: public:
virtual ~GraphicsContext();
/// Makes the graphics context current for the caller thread /// Makes the graphics context current for the caller thread
virtual void MakeCurrent() = 0; virtual void MakeCurrent() = 0;