flodavid/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

FS: Recursively create directories for CreateDirectory

Browse source 
Originally we only created the parent directory, this caused issues for creating directories which also contained subdirectories, eg `/Folder1/Folder2`

This allows the ultimate mod manager homebrew to at least boot
This commit is contained in:
Chloe Marcec 2021-09-06 19:35:55 +10:00
parent b2572a56d3
commit 0b891c9245
1 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/core/hle/service/filesystem/filesystem.cpp
View file

@ -97,15 +97,20 @@ ResultCode VfsDirectoryServiceWrapper::DeleteFile(const std::string& path_) cons
ResultCode VfsDirectoryServiceWrapper::CreateDirectory(const std::string& path_) const { ResultCode VfsDirectoryServiceWrapper::CreateDirectory(const std::string& path_) const {
std::string path(Common::FS::SanitizePath(path_)); std::string path(Common::FS::SanitizePath(path_));
auto dir = GetDirectoryRelativeWrapped(backing, Common::FS::GetParentPath(path)); const auto components = Common::FS::SplitPathComponents(path);
if (dir == nullptr || Common::FS::GetFilename(Common::FS::GetParentPath(path)).empty()) { std::string relative_path = "";
dir = backing; for (const auto& component : components) {
// Skip empty path components
if (component.empty()) {
continue;
} }
auto new_dir = dir->CreateSubdirectory(Common::FS::GetFilename(path)); relative_path = Common::FS::SanitizePath(relative_path + '/' + component);
auto new_dir = backing->CreateSubdirectory(relative_path);
if (new_dir == nullptr) { if (new_dir == nullptr) {
// TODO(DarkLordZach): Find a better error code for this // TODO(DarkLordZach): Find a better error code for this
return ResultUnknown; return ResultUnknown;
} }
}
return ResultSuccess; return ResultSuccess;
} }