flodavid/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

kernel/vm_manager: Remove redundant Reset call in destructor

Browse source 
This is performing more work than would otherwise be necessary during
VMManager's destruction. All we actually want to occur in this scenario
is for any allocated memory to be freed, which will happen automatically
as the VMManager instance goes out of scope.

Anything else being done is simply unnecessary work.
This commit is contained in:
Lioncash 2019-06-12 16:09:57 -04:00
parent 7e2bcf04b4
commit 0af3b4d9f4
No known key found for this signature in database
GPG key ID: 4E3C3CC1031BA9C7
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/core/hle/kernel/vm_manager.cpp
View file

@ -68,9 +68,7 @@ VMManager::VMManager(Core::System& system) : system{system} {
Reset(FileSys::ProgramAddressSpaceType::Is39Bit); Reset(FileSys::ProgramAddressSpaceType::Is39Bit);
} }
VMManager::~VMManager() { VMManager::~VMManager() = default;
Reset(FileSys::ProgramAddressSpaceType::Is39Bit);
}
void VMManager::Reset(FileSys::ProgramAddressSpaceType type) { void VMManager::Reset(FileSys::ProgramAddressSpaceType type) {
Clear(); Clear();