comex
91eb5afd0b
Warnings cleanup for GCC 13 and Clang 16
...
Note: For GCC there are still a huge number of `-Warray-bounds` warnings
coming from `externals/dynarmic`. I could have added a workaround in
`externals/CMakeLists.txt` similar to what this PR does for other
externals, but given Dynarmic's close affiliation with Yuzu, it would be
better to fix it upstream.
Besides that, on my machine, this makes the build warning-free except
for some warnings from glslangValidator and AutoMoc.
Details:
- Disable some warnings in externals.
- Disable `-Wnullability-completeness`, which is a Clang warning triggered
by the Vulkan SDK where if any pointers in the header are marked
_Nullable, it wants all pointers to be marked _Nullable or _Nonnull.
Most of them are, but some aren't. Who knows why.
- `src/web_service/verify_user_jwt.cpp`: Disable another warning when
including `jwt.hpp`.
- `src/input_common/input_poller.cpp`: Add missing `override` specifiers.
- src/common/swap.h: Remove redundant `operator&`. In general, this
file declares three overloads of each operator. Using `+` as an
example, the overloads are:
- a member function for `swapped_t + integer`
- a member function for `swapped_t + swapped_t`
- a free function for `integer + swapped_t`
But for `operator&`, there was an additional free function for
`swapped_t + integer`, which was redundant with the member function.
This caused a GCC warning saying "ISO C++ says that these are
ambiguous".
2023-08-25 19:22:31 -04:00
liamwhite
ef61d129d3
Merge pull request #11303 from lat9nq/screenshots-configurable
...
yuzu-qt: Add configuration for screenshot resolution
2023-08-22 11:30:25 -04:00
lat9nq
6fe51b48e9
yuzu-qt: Screenshots depend more on the graphics settings
2023-08-16 16:12:42 -04:00
lat9nq
96c98d09cb
yuzu-qt: Implement unspecified screenshot ratio
2023-08-16 00:18:47 -04:00
lat9nq
3e28e85468
settings: Add AspectRatio enum, split res scale function
2023-08-15 22:41:50 -04:00
Liam
50eee9b218
fssystem: rework for yuzu style
2023-08-15 17:47:40 -04:00
Liam
86f6b6b7b2
vfs: expand support for NCA reading
2023-08-15 17:47:25 -04:00
Liam
023b9b38cc
general: fix apple clang build
2023-08-09 22:38:37 -04:00
liamwhite
fca7d975fd
Merge pull request #10839 from lat9nq/pgc-plus
...
general: Reimplement per-game configurations
2023-08-02 14:25:52 -04:00
Morph
bb4e676155
wall_clock: Increase precision requirements
...
We are providing a conversion to nanoseconds in NativeClock, which is more precise than the GPU tick.
2023-07-27 18:40:56 -04:00
liamwhite
d3da1e6517
Merge pull request #10990 from comex/ubsan
...
Fixes and workarounds to make UBSan happier on macOS
2023-07-26 10:33:28 -04:00
lat9nq
195403c87c
(ui)settings: Add more runtime_modifiable settings
2023-07-25 23:14:13 -04:00
lat9nq
1bc0b673aa
backend: Remove usage of explicit operator overload
...
Causes a crash on MSVC from a race condition on application quit.
Intended to address yuzu-emu/yuzu/issues/11137
2023-07-25 22:53:58 -04:00
lat9nq
397333b2d5
settings: Correct Linkage member impl location
2023-07-25 15:57:55 -04:00
lat9nq
b1716a9e14
settings: Set GPU as default ASTC decoder
2023-07-24 16:28:13 -04:00
lat9nq
f84e7b4656
settings_common: Document specializations
2023-07-23 16:21:08 -04:00
lat9nq
17b9c1e171
common,qt-config: Remove usage of forward_list
2023-07-21 23:09:09 -04:00
liamwhite
8927f016e1
Merge pull request #11069 from lat9nq/mingw-no-tzdb
...
common: Use arithmetic instead of string ops to get time zone
2023-07-21 15:05:59 -04:00
lat9nq
2911988b85
settings_common: Use a vector in category linkage
...
Improve storage requirements.
2023-07-21 10:56:55 -04:00
lat9nq
ffb384463f
settings: Remove sorting from log
...
Unecessary, and would run every time the settings are logged.
2023-07-21 10:56:55 -04:00
lat9nq
3211623192
common: Move global configuration state modifiers back to settings
2023-07-21 10:56:55 -04:00
lat9nq
b02e7eea78
settings_setting: Fix typo
2023-07-21 10:56:55 -04:00
lat9nq
1e093767a8
common,configure_system: Rename method to GetCategory
...
Fixes essentially a shadowing issue.
2023-07-21 10:56:55 -04:00
lat9nq
267f3c7905
settings: Cleanup
...
Addresses review feedback
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
2023-07-21 10:56:55 -04:00
lat9nq
127b3da0f1
core,common: Give memory layout setting an enum
...
Allows for 6GB and 8GB layouts to be selected.
2023-07-21 10:56:55 -04:00
lat9nq
ff6a5031d5
settings: Require time zone setting value for stirng
2023-07-21 10:56:55 -04:00
lat9nq
e7f01128f1
settings: Give indices to enums
2023-07-21 10:56:55 -04:00
lat9nq
52cc7b438b
settings_common: Remove unncessary enum spec
2023-07-21 10:56:55 -04:00
lat9nq
8497fb0a04
settings_enums: Remove casting
...
Not sure how I missed this earlier, but these vectors can be constructed
using the type of the enum.
2023-07-21 10:56:55 -04:00
lat9nq
54d58130a0
settings_setting: Silence shadowing warnings
2023-07-21 10:56:55 -04:00
lat9nq
926f3e3d3e
settings,configuration: Add a default suffix
2023-07-21 10:56:55 -04:00
lat9nq
7f708e8d77
settings: Define paired settings
...
settings_common: Remove unused optional
2023-07-21 10:56:55 -04:00
lat9nq
b2438f1fb7
settings: Define specializations for settings
...
Suggests to a frontend how to represent each setting.
2023-07-21 10:56:55 -04:00
lat9nq
8b28aa45b9
settings,translation: Fix time zone enum
...
Renames enum values to conform to naming convention.
2023-07-21 10:56:55 -04:00
lat9nq
8366736b67
settings,opengl,yuzu-qt: Fix AA, Filter maximums
...
The new enum macros don't support setting values directly.
For LastAA and LastFilter, this means we need a simpler approach to loop
around the toggle in the frontend...
2023-07-21 10:56:55 -04:00
lat9nq
7ffbffe170
settings_enums: More aggressively use macros
...
This lets us define an enum and all the textual representations
of its values in one swing. All for the price of some ugly macros.
2023-07-21 10:56:55 -04:00
lat9nq
fdbeb84168
settings,uisettings: Remove leading underscore
2023-07-21 10:56:55 -04:00
lat9nq
3a7705e774
settings: Move speed_limit to core
2023-07-21 10:56:55 -04:00
lat9nq
3f0cc544cf
common,yuzu-qt: Avoid explicit instantiation on old clang
...
Clang versions < 15 have compile issues with explicit instantiation.
Disable it for these versions.
2023-07-21 10:56:55 -04:00
lat9nq
c97cbd089b
settings_setting: Fix MSVC error
2023-07-21 10:56:55 -04:00
lat9nq
ee32b17782
common,yuzu-qt: GCC warning silences
...
Fixes -Wshadow, -Wdeprecated, and catch by copy rather than by ref.
2023-07-21 10:56:55 -04:00
lat9nq
a0883526d6
settings: Delete cpu_accuracy_first_time
...
Almost a 2 year old migration setting now
2023-07-21 10:56:54 -04:00
lat9nq
27e53990ed
settings: Document BasicSetting, add Ranged
2023-07-21 10:56:54 -04:00
lat9nq
b4f2ad3ff5
settings: Move IsConfiguringGlobal to settings_common
2023-07-21 10:56:54 -04:00
lat9nq
11e7e1b8ce
settings: Move some simple data to BasicSetting
...
Reduces the need for the compiler to duplicate this code, by about
100KB executable size.
2023-07-21 10:56:54 -04:00
lat9nq
4903f40efe
settings_setting: Fix errors
...
ToString didn't have a constexpr if statement where needed.
Canonicalize missed an else, causing unreachable code error on MSVC.
2023-07-21 10:56:54 -04:00
lat9nq
04d4b6ab80
(ui,)settings: Use explicit instantiation
...
Reduces compile times a tad on clang.
2023-07-21 10:56:54 -04:00
lat9nq
02265f19d9
settings: Remove redundant false literals
2023-07-21 10:56:54 -04:00
lat9nq
0193add060
general: Add typeinfo where needed
...
Using typeid without including typeinfo first produces an ill-formed program.
2023-07-21 10:56:54 -04:00
lat9nq
2fba913d0b
settings_enums: Add const type where needed
2023-07-21 10:56:54 -04:00