eitan.c/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

audio_buffers: Pass by const-ref in AppendBuffers

Browse source 
This function doesn't modify the passed in buffer, so we can make that
explicit.
This commit is contained in:
Lioncash 2022-09-16 09:36:00 -04:00
parent cb2a33babc
commit e9109cb5f2
3 changed files with 17 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/audio_core/device/audio_buffers.h
View file

@ -36,7 +36,7 @@ public:
* *
* @param buffer - The new buffer. * @param buffer - The new buffer.
*/ */
void AppendBuffer(AudioBuffer& buffer) { void AppendBuffer(const AudioBuffer& buffer) {
std::scoped_lock l{lock}; std::scoped_lock l{lock};
buffers[appended_index] = buffer; buffers[appended_index] = buffer;
appended_count++; appended_count++;

14
src/audio_core/in/audio_in_system.cpp
View file

@ -114,12 +114,14 @@ bool System::AppendBuffer(const AudioInBuffer& buffer, const u64 tag) {
} }
const auto timestamp{buffers.GetNextTimestamp()}; const auto timestamp{buffers.GetNextTimestamp()};
AudioBuffer new_buffer{.start_timestamp = timestamp, const AudioBuffer new_buffer{
.end_timestamp = timestamp + buffer.size / (channel_count * sizeof(s16)), .start_timestamp = timestamp,
.played_timestamp = 0, .end_timestamp = timestamp + buffer.size / (channel_count * sizeof(s16)),
.samples = buffer.samples, .played_timestamp = 0,
.tag = tag, .samples = buffer.samples,
.size = buffer.size}; .tag = tag,
.size = buffer.size,
};
buffers.AppendBuffer(new_buffer); buffers.AppendBuffer(new_buffer);
RegisterBuffers(); RegisterBuffers();

14
src/audio_core/out/audio_out_system.cpp
View file

@ -113,12 +113,14 @@ bool System::AppendBuffer(const AudioOutBuffer& buffer, u64 tag) {
} }
const auto timestamp{buffers.GetNextTimestamp()}; const auto timestamp{buffers.GetNextTimestamp()};
AudioBuffer new_buffer{.start_timestamp = timestamp, const AudioBuffer new_buffer{
.end_timestamp = timestamp + buffer.size / (channel_count * sizeof(s16)), .start_timestamp = timestamp,
.played_timestamp = 0, .end_timestamp = timestamp + buffer.size / (channel_count * sizeof(s16)),
.samples = buffer.samples, .played_timestamp = 0,
.tag = tag, .samples = buffer.samples,
.size = buffer.size}; .tag = tag,
.size = buffer.size,
};
buffers.AppendBuffer(new_buffer); buffers.AppendBuffer(new_buffer);
RegisterBuffers(); RegisterBuffers();