eitan.c/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

file_util: Check for is_trivially_copyable

Browse source 
Also applies the template checks to ReadArray as well.
This commit is contained in:
Lioncash 2016-04-13 19:20:23 -04:00
parent 3ee4432fe3
commit bf9945b81b
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/common/file_util.h
View file

@ -192,6 +192,9 @@ public:
template <typename T> template <typename T>
size_t ReadArray(T* data, size_t length) size_t ReadArray(T* data, size_t length)
{ {
static_assert(std::is_standard_layout<T>(), "Given array does not consist of standard layout objects");
static_assert(std::is_trivially_copyable<T>(), "Given array does not consist of trivially copyable objects");
if (!IsOpen()) { if (!IsOpen()) {
m_good = false; m_good = false;
return -1; return -1;
@ -207,9 +210,8 @@ public:
template <typename T> template <typename T>
size_t WriteArray(const T* data, size_t length) size_t WriteArray(const T* data, size_t length)
{ {
static_assert(std::is_standard_layout<T>::value, "Given array does not consist of standard layout objects"); static_assert(std::is_standard_layout<T>(), "Given array does not consist of standard layout objects");
// TODO: gcc 4.8 does not support is_trivially_copyable, but we really should check for it here. static_assert(std::is_trivially_copyable<T>(), "Given array does not consist of trivially copyable objects");
//static_assert(std::is_trivially_copyable<T>::value, "Given array does not consist of trivially copyable objects");
if (!IsOpen()) { if (!IsOpen()) {
m_good = false; m_good = false;