eitan.c/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

Common: Don't return a reference to a string when calling GetName in symbols.cpp

Browse source 
Returning a copy of the string is what was likely meant to be done.
This commit is contained in:
Lioncash 2014-08-18 01:58:59 -04:00
parent 68c81f28d9
commit a49a5fa4d9
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/common/symbols.cpp
View file

@ -40,7 +40,7 @@ namespace Symbols
return symbol; return symbol;
} }
const std::string& GetName(u32 _address) const std::string GetName(u32 _address)
{ {
return GetSymbol(_address).name; return GetSymbol(_address).name;
} }

2
src/common/symbols.h
View file

@ -32,7 +32,7 @@ namespace Symbols
void Add(u32 _address, const std::string& _name, u32 _size, u32 _type); void Add(u32 _address, const std::string& _name, u32 _size, u32 _type);
TSymbol GetSymbol(u32 _address); TSymbol GetSymbol(u32 _address);
const std::string& GetName(u32 _address); const std::string GetName(u32 _address);
void Remove(u32 _address); void Remove(u32 _address);
void Clear(); void Clear();
}; };