eitan.c/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

fsmitm_romfsbuild: Remove unnecessary constructors and initializers for RomFSBuildFileContext and RomFSBuildDirectoryContext

Browse source 
There's no need to duplicate in-class initializers with a constructor
initializer list. std::strings also initialize to empty by default.
This commit is contained in:
Lioncash 2018-09-25 18:17:42 -04:00
parent 1f92cbc059
commit 91b56c4928
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/core/file_sys/fsmitm_romfsbuild.cpp
View file

@ -73,7 +73,7 @@ static_assert(sizeof(RomFSFileEntry) == 0x20, "RomFSFileEntry has incorrect size
struct RomFSBuildFileContext; struct RomFSBuildFileContext;
struct RomFSBuildDirectoryContext { struct RomFSBuildDirectoryContext {
std::string path = ""; std::string path;
u32 cur_path_ofs = 0; u32 cur_path_ofs = 0;
u32 path_len = 0; u32 path_len = 0;
u32 entry_offset = 0; u32 entry_offset = 0;
@ -84,7 +84,7 @@ struct RomFSBuildDirectoryContext {
}; };
struct RomFSBuildFileContext { struct RomFSBuildFileContext {
std::string path = ""; std::string path;
u32 cur_path_ofs = 0; u32 cur_path_ofs = 0;
u32 path_len = 0; u32 path_len = 0;
u32 entry_offset = 0; u32 entry_offset = 0;
@ -92,9 +92,7 @@ struct RomFSBuildFileContext {
u64 size = 0; u64 size = 0;
std::shared_ptr<RomFSBuildDirectoryContext> parent; std::shared_ptr<RomFSBuildDirectoryContext> parent;
std::shared_ptr<RomFSBuildFileContext> sibling; std::shared_ptr<RomFSBuildFileContext> sibling;
VirtualFile source = nullptr; VirtualFile source;
RomFSBuildFileContext() : path(""), cur_path_ofs(0), path_len(0) {}
}; };
static u32 romfs_calc_path_hash(u32 parent, std::string path, u32 start, std::size_t path_len) { static u32 romfs_calc_path_hash(u32 parent, std::string path, u32 start, std::size_t path_len) {