1
0
Fork 0
forked from suyu/suyu

game_list: Only reload game list after relevant settings changed

Prevents unnecessary reloads on every configuration operation.
This commit is contained in:
Zach Hilman 2018-11-03 20:38:39 -04:00
parent 6664d7b2c5
commit 52e7e8eed3
5 changed files with 28 additions and 1 deletions

View file

@ -36,6 +36,16 @@ ConfigureGameList::ConfigureGameList(QWidget* parent)
InitializeRowComboBoxes();
this->setConfiguration();
// Force game list reload if any of the relevant settings are changed.
connect(ui->show_unknown, &QCheckBox::stateChanged, this,
&ConfigureGameList::RequestGameListUpdate);
connect(ui->icon_size_combobox, QOverload<int>::of(&QComboBox::currentIndexChanged), this,
&ConfigureGameList::RequestGameListUpdate);
connect(ui->row_1_text_combobox, QOverload<int>::of(&QComboBox::currentIndexChanged), this,
&ConfigureGameList::RequestGameListUpdate);
connect(ui->row_2_text_combobox, QOverload<int>::of(&QComboBox::currentIndexChanged), this,
&ConfigureGameList::RequestGameListUpdate);
}
ConfigureGameList::~ConfigureGameList() = default;
@ -48,6 +58,10 @@ void ConfigureGameList::applyConfiguration() {
Settings::Apply();
}
void ConfigureGameList::RequestGameListUpdate() {
UISettings::values.is_game_list_reload_pending.exchange(true);
}
void ConfigureGameList::setConfiguration() {
ui->show_unknown->setChecked(UISettings::values.show_unknown);
ui->icon_size_combobox->setCurrentIndex(

View file

@ -21,6 +21,8 @@ public:
void applyConfiguration();
private:
void RequestGameListUpdate();
void setConfiguration();
void changeEvent(QEvent*) override;

View file

@ -19,6 +19,9 @@ ConfigureGeneral::ConfigureGeneral(QWidget* parent)
this->setConfiguration();
connect(ui->toggle_deepscan, &QCheckBox::stateChanged, this,
[] { UISettings::values.is_game_list_reload_pending.exchange(true); });
ui->use_cpu_jit->setEnabled(!Core::System::GetInstance().IsPoweredOn());
ui->use_docked_mode->setEnabled(!Core::System::GetInstance().IsPoweredOn());
}

View file

@ -1328,7 +1328,13 @@ void GMainWindow::OnConfigure() {
UpdateUITheme();
if (UISettings::values.enable_discord_presence != old_discord_presence)
SetDiscordEnabled(UISettings::values.enable_discord_presence);
game_list->PopulateAsync(UISettings::values.gamedir, UISettings::values.gamedir_deepscan);
const auto reload = UISettings::values.is_game_list_reload_pending.exchange(false);
if (reload) {
game_list->PopulateAsync(UISettings::values.gamedir,
UISettings::values.gamedir_deepscan);
}
config->Save();
}
}

View file

@ -5,6 +5,7 @@
#pragma once
#include <array>
#include <atomic>
#include <vector>
#include <QByteArray>
#include <QString>
@ -62,6 +63,7 @@ struct Values {
uint32_t icon_size;
uint8_t row_1_text_id;
uint8_t row_2_text_id;
std::atomic_bool is_game_list_reload_pending{false};
};
extern Values values;