eitan.c/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

kernel/thread: Avoid sign conversion within GetCommandBufferAddress()

Browse source 
Previously this was performing a u64 + int sign conversion. When dealing
with addresses, we should generally be keeping the arithmetic in the
same signedness type.

This also gets rid of the static lifetime of the constant, as there's no
need to make a trivial type like this potentially live for the entire
duration of the program.
This commit is contained in:
Lioncash 2019-04-01 17:59:43 -04:00
parent 26d0381161
commit 2d70c30fb2
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/core/hle/kernel/thread.cpp
View file

@ -237,8 +237,8 @@ s32 Thread::GetWaitObjectIndex(const WaitObject* object) const {
VAddr Thread::GetCommandBufferAddress() const { VAddr Thread::GetCommandBufferAddress() const {
// Offset from the start of TLS at which the IPC command buffer begins. // Offset from the start of TLS at which the IPC command buffer begins.
static constexpr int CommandHeaderOffset = 0x80; constexpr u64 command_header_offset = 0x80;
return GetTLSAddress() + CommandHeaderOffset; return GetTLSAddress() + command_header_offset;
} }
void Thread::SetStatus(ThreadStatus new_status) { void Thread::SetStatus(ThreadStatus new_status) {