ahmed2007/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity
7358 commits 22 branches 3 tags 306 MiB
Commit graph

6169 commits

Author SHA1 Message Date
Lioncash
1c16700372 nro: Remove unused forward declaration 
This isn't used anywhere in the header.
 2018-07-23 17:19:42 -04:00
bunnei
07e5319d55
Merge pull request #695 from DarkLordZach/nro-asset 
NRO Assets and NACP File Format
 2018-07-23 14:14:11 -07:00
Lioncash
3b88ce3dcb gl_shader_decompiler: Simplify GetCommonDeclarations() 2018-07-23 17:11:18 -04:00
Lioncash
1432912ae8 vi: Add std::is_trivially_copyable checks to Read and Write functions 
It's undefined behavior to memcpy an object that isn't considered
trivially copyable, so put a compile-time check in to make sure this
doesn't occur.
 2018-07-23 14:53:54 -04:00
Lioncash
344a0c91f2 vi: std::move std::vector in constructors where applicable 
Allows avoiding unnecessary copies of the vector depending on the
calling code.

While we're at it, remove a redundant no-parameter base constructor call
 2018-07-23 14:49:54 -04:00
Lioncash
cbe841c9c9 hle: Remove config_mem.h/.cpp 
This is just an unused hold-over from citra, so we can get rid of this
to trim off an exposed global, among other things.
 2018-07-23 12:57:34 -04:00
Lioncash
1f3889a290 hle: Remove shared_page.h/.cpp 
This is a holdover from citra that's essentially unused.
 2018-07-23 12:53:07 -04:00
Lioncash
e85308cd90 set: Add missing log call in GetAvailableLanguageCodeCount() 
Forgot to include this in 22f448b632
 2018-07-23 12:37:42 -04:00
bunnei
7138b99f21
Merge pull request #775 from lioncash/str 
string_util: Minor changes
 2018-07-23 09:34:41 -07:00
Zach Hilman
e8f641a52d NRO Assets and NACP file format 
Cleanup

Review fixes
 2018-07-23 12:34:26 -04:00
bunnei
a85366a40c
Merge pull request #777 from lioncash/lang 
set: Amend return value of GetAvailableLanguageCodes()
 2018-07-23 09:34:08 -07:00
Lioncash
22f448b632 set: Implement GetAvailableLanguageCodeCount() 
This just returns the size of the language code buffer.
 2018-07-23 00:29:40 -04:00
Lioncash
37aeecd29f set: Correct return code size of value in GetAvailableLanguageCodes() 
The return code should be 32-bit in size.
 2018-07-23 00:29:22 -04:00
bunnei
e85a528bb9
Merge pull request #769 from bunnei/shader-mask-fixes 
shader_bytecode: Implement other TEXS masks.
 2018-07-22 18:03:31 -07:00
Lioncash
9d33122197 string_util: Get rid of separate resize() in CPToUTF16(), UTF16ToUTF8(), CodeToUTF8() and UTF8ToUTF16() 
There's no need to perform the resize separately here, since the
constructor allows presizing the buffer.

Also move the empty string check before the construction of the string
to make the early out more straightforward.
 2018-07-22 16:39:21 -04:00
Lioncash
26a157cd31 string_util: Use emplace_back() in SplitString() instead of push_back() 
This is equivalent to doing:

push_back(std::string(""));

which is likely not to cause issues, assuming a decent std::string
implementation with small-string optimizations implemented in its
design, however it's still a little unnecessary to copy that buffer
regardless. Instead, we can use emplace_back() to directly construct the
empty string within the std::vector instance, eliminating any possible
overhead from the copy.
 2018-07-22 15:36:32 -04:00
Lioncash
cd46b267f5 string_util: Remove unnecessary std::string instance in TabsToSpaces() 
We can just use the variant of std::string's replace() function that can
replace an occurrence with N copies of the same character, eliminating
the need to allocate a std::string containing a buffer of spaces.
 2018-07-22 15:35:48 -04:00
bunnei
a4b2af7382
Merge pull request #774 from Subv/atomic_signal 
Kernel/SVC: Perform atomic accesses in SignalProcessWideKey as per the real kernel.
 2018-07-22 12:26:03 -07:00
bunnei
c994cdc532
Merge pull request #773 from Subv/gl_ext_check 
Frontend: Check for more required OpenGL extensions during startup.
 2018-07-22 11:47:07 -07:00
bunnei
5ee4c49c30
Merge pull request #768 from lioncash/string-view 
file_util, vfs: Use std::string_view where applicable
 2018-07-22 11:32:28 -07:00
Subv
7841447cf0 Kernel/SVC: Perform atomic accesses in SignalProcessWideKey as per the real kernel. 2018-07-22 12:27:24 -05:00
bunnei
3618a68f93
Merge pull request #770 from lioncash/construct 
gl_shader_decompiler: Remove redundant Subroutine construction in AddSubroutine()
 2018-07-22 10:24:20 -07:00
Subv
ba2fb83d60 Frontend: Check for more required OpenGL extensions during startup. 2018-07-22 12:05:38 -05:00
MerryMage
0b1c2e5505 Implement exclusive monitor 2018-07-22 15:55:17 +01:00
Lioncash
0797657bc0 gl_shader_decompiler: Remove redundant Subroutine construction in AddSubroutine() 
We don't need to toss away the Subroutine instance after the find() call
and reconstruct another instance with the same data right after it.
Particularly give Subroutine contains a std::set.
 2018-07-22 03:30:35 -04:00
bunnei
148a5bef7e shader_bytecode: Implement other TEXS masks. 2018-07-22 03:23:15 -04:00
Lioncash
0081252d31 vfs: Correct file_p variable usage within InterpretAsDirectory() 
ReplaceFileWithSubdirectory() takes a VirtualFile and a VirtualDir, but
it was being passed a string as one of its arguments. The only reason
this never caused issues is because this template isn't instantiated
anywhere yet.

This corrects an issue before it occurs.
 2018-07-22 03:22:28 -04:00
Lioncash
398444e676 file_util, vfs: Use std::string_view where applicable 
Avoids unnecessary construction of std::string instances where
applicable.
 2018-07-22 03:22:21 -04:00
bunnei
258a5cee84
Merge pull request #765 from lioncash/file 
file_util: Remove goto usages from Copy()
 2018-07-22 00:03:35 -07:00
bunnei
af4bde8cd1
Merge pull request #767 from bunnei/shader-cleanup 
gl_shader_decompiler: Remove unused state tracking and minor cleanup.
 2018-07-22 00:03:17 -07:00
bunnei
2d563ec8d5
Merge pull request #766 from bunnei/shader-sel 
gl_shader_decompiler: Implement SEL instruction.
 2018-07-21 23:13:27 -07:00
bunnei
ef163c1a15
Merge pull request #764 from lioncash/move 
file_util: Minor changes to ScanDirectoryTree() and ForeachDirectoryEntry()
 2018-07-21 22:05:30 -07:00
bunnei
f5a2944ab6 gl_shader_decompiler: Remove unused state tracking and minor cleanup. 2018-07-22 01:00:44 -04:00
bunnei
c43eaa94f3 gl_shader_decompiler: Implement SEL instruction. 2018-07-22 00:37:12 -04:00
Lioncash
c5de0a67a8 file_util: Remove goto usages from Copy() 
We can just leverage std::unique_ptr to automatically close these for us
in error cases instead of jumping to the end of the function to call
fclose on them.
 2018-07-21 23:08:55 -04:00
Lioncash
0ba7fe4ab1 file_util: Use a u64 to represent number of entries 
This avoids a truncating cast on size. I doubt we'd ever traverse a
directory this large, however we also shouldn't truncate sizes away.
 2018-07-21 22:42:08 -04:00
Lioncash
964154ce44 file_util: std::move FST entries in ScanDirectoryTree() 
Avoids unnecessary copies when building up the FST entries.
 2018-07-21 22:31:44 -04:00
bunnei
63fbf9a7d3 gl_rasterizer_cache: Blit surfaces on recreation instead of flush and load. 2018-07-21 21:51:06 -04:00
bunnei
4301f0b539 gl_rasterizer_cache: Use GPUVAddr as cache key, not parameter set. 2018-07-21 21:51:06 -04:00
bunnei
cd47391c2d gl_rasterizer_cache: Use zeta_width and zeta_height registers for depth buffer. 2018-07-21 21:51:06 -04:00
bunnei
d8c60029d6 gl_rasterizer: Use zeta_enable register to enable depth buffer. 2018-07-21 21:51:06 -04:00
bunnei
5287991a36 maxwell_3d: Add depth buffer enable, width, and height registers. 2018-07-21 21:51:05 -04:00
bunnei
53a219f163
Merge pull request #759 from lioncash/redundant 
file_util: Remove redundant duplicate return in GetPathWithoutTop()
 2018-07-21 18:50:38 -07:00
bunnei
3ac736c003
Merge pull request #748 from lioncash/namespace 
video_core: Use nested namespaces where applicable
 2018-07-21 18:50:14 -07:00
bunnei
f5e87f4ce1
Merge pull request #758 from lioncash/sync 
common: Remove synchronized_wrapper.h
 2018-07-21 18:30:31 -07:00
bunnei
9533875eeb
Merge pull request #760 from lioncash/path 
file_util: Use an enum class for GetUserPath()
 2018-07-21 18:30:04 -07:00
Subv
5c49e56d41 GPU: Implement the NVGPU_IOCTL_CHANNEL_KICKOFF_PB ioctl2 command. 
This behaves quite similarly to the SubmitGPFIFO command. Referenced from Ryujinx.
Many thanks to @gdkchan for investigating this!
 2018-07-21 15:50:02 -05:00
Lioncash
d66b43dadf file_util: Use an enum class for GetUserPath() 
Instead of using an unsigned int as a parameter and expecting a user to
always pass in the correct values, we can just convert the enum into an
enum class and use that type as the parameter type instead, which makes
the interface more type safe.

We also get rid of the bookkeeping "NUM_" element in the enum by just
using an unordered map. This function is generally low-frequency in
terms of calls (and I'd hope so, considering otherwise would mean we're
slamming the disk with IO all the time) so I'd consider this acceptable
in this case.
 2018-07-21 16:21:19 -04:00
Lioncash
34d6a1349c file_util: Remove explicit type from std::min() in GetPathWithoutTop() 
Given both operands are the same type, there won't be an issue with
overload selection that requires making this explicit.
 2018-07-21 15:19:32 -04:00
Lioncash
41660c8923 file_util: Remove redundant duplicate return in GetPathWithoutTop() 2018-07-21 15:18:23 -04:00
Lioncash
973fdce79b common: Remove synchronized_wrapper.h 
This is entirely unused in the codebase.
 2018-07-21 14:51:44 -04:00
bunnei
0f20fa5a1e
Merge pull request #754 from lioncash/part 
partition_filesystem, vfs_real: Minor changes
 2018-07-21 11:38:52 -07:00
bunnei
de7cb91995
Merge pull request #750 from lioncash/ctx 
arm_interface: Remove unused tls_address member of ThreadContext
 2018-07-21 11:38:16 -07:00
bunnei
1c7c1347d8
Merge pull request #746 from lioncash/tests 
tests/arm_test_common: Minor changes
 2018-07-21 10:55:29 -07:00
bunnei
ff8754f921
Merge pull request #747 from lioncash/unimplemented 
gl_shader_manager: Remove unimplemented function prototype
 2018-07-21 10:54:58 -07:00
bunnei
89cc8c1617
Merge pull request #755 from lioncash/ctor 
file_sys/errors: Remove redundant object constructor calls
 2018-07-21 10:53:53 -07:00
bunnei
552aac7e6c
Merge pull request #749 from lioncash/consistency 
gpu: Rename Get3DEngine() to Maxwell3D()
 2018-07-21 10:51:00 -07:00
bunnei
fe2498a650
Merge pull request #751 from Subv/tpidr_el0 
CPU: Save and restore the TPIDR_EL0 system register on every context switch
 2018-07-21 10:48:30 -07:00
bunnei
3d938b8c60
Merge pull request #753 from lioncash/const 
vfs: Minor changes
 2018-07-21 10:44:08 -07:00
bunnei
d85cfc94e2
Merge pull request #752 from Subv/vfs_load 
Loader: Only print the module names and addresses if they actually exist.
 2018-07-20 22:57:18 -07:00
Lioncash
459e158340 file_sys/errors: Remove redundant object constructor calls 
Given we're already constructing the error code, we don't need to call
the constructor inside of it.
 2018-07-20 22:37:54 -04:00
Lioncash
b46c0ed1fa vfs_real: Remove redundant copying of std::vector instances in GetFiles() and GetSubdirectories() 
We already return by value, so we don't explicitly need to make the
copy.
 2018-07-20 22:30:22 -04:00
Lioncash
ec71915ede partition_filesystem, vfs_real: Add missing standard includes 2018-07-20 22:28:35 -04:00
Lioncash
d36e327ba6 partition_filesystem, vfs_real: Use std::move in ReplaceFileWithSubdirectory() where applicable 
Avoids unnecessary atomic increment and decrement operations.
 2018-07-20 22:23:58 -04:00
Lioncash
2b91386e15 partition_filesystem, vfs_real: Use std::distance() instead of subtraction 
This is a little bit more self-documenting on what is being done here.
 2018-07-20 22:19:17 -04:00
Lioncash
3e0727df1b vfs_offset: Simplify TrimToFit() 
We can simply use std::clamp() here, instead of using an equivalent
with std::max() and std::min().
 2018-07-20 22:04:37 -04:00
Lioncash
894b0de0f2 vfs: Make WriteBytes() overload taking a std::vector pass the std::vector by const reference 
Given the data is intended to be directly written, there's no need to
take the std::vector by value and copy the data.
 2018-07-20 21:51:30 -04:00
Lioncash
dd09439fee vfs: Use variable template variants of std::is_trivially_copyable 
Provides the same behavior, but with less writing
 2018-07-20 21:47:19 -04:00
Lioncash
05231d8b08 vfs: Amend constness on pointers in WriteBytes() and WriteArrays() member functions to be const qualified 
These functions don't modify the data being pointed to, so these can be
pointers to const data
 2018-07-20 21:40:15 -04:00
Subv
966874e357 Loader: Only print the module names and addresses if they actually exist. 2018-07-20 19:59:15 -05:00
Subv
d84eb9dac6 CPU: Save and restore the TPIDR_EL0 system register on every context switch. 
Note that there's currently a dynarmic bug preventing this register from being written.
 2018-07-20 19:57:45 -05:00
bunnei
8afc21f175
Merge pull request #743 from lioncash/view 
logging: Use std::string_view where applicable
 2018-07-20 17:17:04 -07:00
bunnei
d4104c72aa
Merge pull request #745 from lioncash/package 
param_package: Minor changes
 2018-07-20 17:16:54 -07:00
Lioncash
ae09adfcb3 arm_interface: Remove unused tls_address member of ThreadContext 
Currently, the TLS address is set within the scheduler, making this
member unused.
 2018-07-20 18:57:40 -04:00
Lioncash
d5bc9aef4e gl_shader_manager: Replace unimplemented function prototype 
This was just a linker error waiting to happen.
 2018-07-20 18:39:54 -04:00
Lioncash
863579736c gpu: Rename Get3DEngine() to Maxwell3D() 
This makes it match its const qualified equivalent.
 2018-07-20 18:34:49 -04:00
Lioncash
bb960c8cb4 video_core: Use nested namespaces where applicable 
Compresses a few namespace specifiers to be more compact.
 2018-07-20 18:23:54 -04:00
bunnei
2b7d862366
Merge pull request #742 from bunnei/misc-apm 
apm: Improve stub for GetPerformanceConfiguration.
 2018-07-20 15:01:19 -07:00
Lioncash
48733744bb arm_test_common: Get rid of truncation warnings 
Explicitly cast the value to a u8 to show that this is intentional.
 2018-07-20 17:53:53 -04:00
Lioncash
a8bb1eb39f arm_test_common: Make file static variable a member variable of the testing environment 
Gets rid of file-static behavior.
 2018-07-20 17:52:37 -04:00
Lioncash
a44475207c arm_test_common: Add missing header guard 2018-07-20 17:48:43 -04:00
Lioncash
3268321f4b param_package: Take std::string by value in string-based Set() function 
Allows avoiding string copies by letting the strings be moved into the
function calls.
 2018-07-20 17:24:06 -04:00
Lioncash
6279c2dcf4 param_package: Use std::unordered_map's insert_or_assign instead of map indexing 
This avoids a redundant std::string construction if a key doesn't exist
in the map already.

e.g.

data[key] requires constructing a new default instance of the value in
the map (but this is wasteful, since we're already setting something
into the map over top of it).
 2018-07-20 17:24:06 -04:00
Lioncash
474ec2ee5f param_package: Get rid of file-static std::string construction 
Avoids potential dynamic allocation occuring during program launch
 2018-07-20 17:24:02 -04:00
Lioncash
f63ccbd936 logging/filter: Use std::string_view in ParseFilterString() 
Allows avoiding constructing std::string instances, since this only
reads an arbitrary sequence of characters.

We can also make ParseFilterRule() internal, since it doesn't depend on
any private instance state of Filter
 2018-07-20 15:58:46 -04:00
Lioncash
7a1a860abe logging/backend: Add missing standard includes 
A few inclusions were being satisfied indirectly. To prevent breakages
in the future, include these directly.
 2018-07-20 15:31:27 -04:00
Lioncash
457d1b4490 logging/backend: Use std::string_view in RemoveBackend() and GetBackend() 
These can just use a view to a string since its only comparing against
two names in both cases for matches. This avoids constructing
std::string instances where they aren't necessary.
 2018-07-20 15:27:20 -04:00
bunnei
dffd154d6d apm: Improve stub for GetPerformanceConfiguration. 2018-07-20 15:20:01 -04:00
Lioncash
0a0b3c4b9f ipc_helpers: Add PushEnum() member function to ResponseBuilder 
Allows pushing strongly-typed enum members without the need to always
cast them at the call sites.

Note that we *only* allow strongly-typed enums in this case. The reason
for this is that strongly typed enums have a guaranteed defined size, so
the size of the data being pushed is always deterministic. With regular
enums this can be a little more error-prone, so we disallow them.

This function simply uses the underlying type of the enum to determine
the size of the data. For example, if an enum is defined as:

enum class SomeEnum : u16 {
  SomeEntry
};

if PushEnum(SomeEnum::SomeEntry); is called, then it will push a
u16-size amount of data.
 2018-07-20 15:00:58 -04:00
bunnei
c1c9ab31e8
Merge pull request #740 from Subv/acc_crash 
HLE/ACC: Stub IManagerForApplication::GetAccountId to return an error.
 2018-07-20 09:47:47 -07:00
bunnei
29f49bd3c1
Merge pull request #738 from lioncash/sign 
gl_state: Get rid of mismatched sign conversions in Apply()
 2018-07-20 09:21:57 -07:00
bunnei
ffbd51e207
Merge pull request #737 from lioncash/move 
filesys/loader: std::move VirtualFile instances in constructors where applicable
 2018-07-20 09:21:15 -07:00
bunnei
701c7cb85c
Merge pull request #736 from lioncash/null 
audout_u/audren_u: Ensure null terminators are written out in ListAudioOutsImpl(), ListAudioDeviceName(), and GetActiveAudioDeviceName()
 2018-07-20 09:17:07 -07:00
bunnei
fbc2bcd4a9
Merge pull request #735 from lioncash/video-unused 
maxwell_3d: Remove unused variable within GetStageTextures()
 2018-07-20 09:16:15 -07:00
bunnei
741cae1e1d
Merge pull request #734 from lioncash/thread 
thread: Convert ThreadStatus into an enum class
 2018-07-20 09:15:52 -07:00
bunnei
a1805ceb0b
Merge pull request #733 from lioncash/dirs 
partition_filesystem: Return pfs_dirs member variable within GetSubdirectories()
 2018-07-20 09:15:16 -07:00
bunnei
86d1649b32
Merge pull request #732 from lioncash/unused 
nso: Minor changes
 2018-07-20 09:14:10 -07:00
bunnei
204d707ce7
Merge pull request #731 from lioncash/shadow 
gl_shader_decompiler: Eliminate variable and declaration shadowing
 2018-07-20 09:13:36 -07:00
Subv
9c7321fe6d HLE/ACC: Stub IManagerForApplication::GetAccountId to return an error. 
And make IManagerForApplication::CheckAvailability always return false.
Returning a bogus id from GetAccountId causes games to crash on boot.
We should investigate this with a hwtest and either stub it properly or implement it.
 2018-07-20 11:02:25 -05:00
Lioncash
0faa13baeb gl_state: Make references const where applicable in Apply() 2018-07-20 01:12:29 -04:00