ahmed2007/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

gl_shader_manager: Take ShaderSetup instances by const reference in UseProgrammableVertexShader() and UseProgrammableFragmentShader()

Browse source 
Avoids performing unnecessary copies of 65560 byte sized ShaderSetup
instances, considering it's only used as part of lookup and not
modified.

Given the parameters were already const, it's likely taking these
parameters by reference was intended but the ampersand was forgotten.
This commit is contained in:
Lioncash 2018-08-02 11:07:07 -04:00
parent a03c644aed
commit d92e8ab062
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/video_core/renderer_opengl/gl_shader_manager.h
View file

@ -105,14 +105,14 @@ public:
} }
ShaderEntries UseProgrammableVertexShader(const MaxwellVSConfig& config, ShaderEntries UseProgrammableVertexShader(const MaxwellVSConfig& config,
const ShaderSetup setup) { const ShaderSetup& setup) {
ShaderEntries result; ShaderEntries result;
std::tie(current.vs, result) = vertex_shaders.Get(config, setup); std::tie(current.vs, result) = vertex_shaders.Get(config, setup);
return result; return result;
} }
ShaderEntries UseProgrammableFragmentShader(const MaxwellFSConfig& config, ShaderEntries UseProgrammableFragmentShader(const MaxwellFSConfig& config,
const ShaderSetup setup) { const ShaderSetup& setup) {
ShaderEntries result; ShaderEntries result;
std::tie(current.fs, result) = fragment_shaders.Get(config, setup); std::tie(current.fs, result) = fragment_shaders.Get(config, setup);
return result; return result;