Various fixes and clang

src/core/hle/service/am/am.cpp

@@ -109,7 +109,7 @@ ISelfController::ISelfController(std::shared_ptr<NVFlinger::NVFlinger> nvflinger
         {61, nullptr, "SetMediaPlaybackState"},
         {62, nullptr, "SetIdleTimeDetectionExtension"},
         {63, nullptr, "GetIdleTimeDetectionExtension"},
-        {64, nullptr, "SetInputDetectionSourceSet"}
+        {64, nullptr, "SetInputDetectionSourceSet"},
         {65, nullptr, "ReportUserIsActive"},
         {66, nullptr, "GetCurrentIlluminance"},
         {67, nullptr, "IsIlluminanceAvailable"},

src/core/hle/service/filesystem/fsp_srv.cpp

@@ -22,12 +22,8 @@ public:
     IStorage(std::unique_ptr<FileSys::StorageBackend>&& backend)
         : ServiceFramework("IStorage"), backend(std::move(backend)) {
         static const FunctionInfo functions[] = {
-            {0, &IStorage::Read, "Read"}, 
+            {0, &IStorage::Read, "Read"}, {1, nullptr, "Write"},   {2, nullptr, "Flush"},
-            {1, nullptr, "Write"},   
+            {3, nullptr, "SetSize"},      {4, nullptr, "GetSize"}, {5, nullptr, "OperateRange"},
-            {2, nullptr, "Flush"},
-            {3, nullptr, "SetSize"},      
-            {4, nullptr, "GetSize"},
-            {5, nullptr, "OperateRange"},
         };
         RegisterHandlers(functions);
     }
@@ -76,12 +72,9 @@ public:
     explicit IFile(std::unique_ptr<FileSys::StorageBackend>&& backend)
         : ServiceFramework("IFile"), backend(std::move(backend)) {
         static const FunctionInfo functions[] = {
-            {0, &IFile::Read, "Read"},       
+            {0, &IFile::Read, "Read"},       {1, &IFile::Write, "Write"},
-            {1, &IFile::Write, "Write"},     
+            {2, nullptr, "Flush"},           {3, &IFile::SetSize, "SetSize"},
-            {2, nullptr, "Flush"},
+            {4, &IFile::GetSize, "GetSize"}, {5, nullptr, "OperateRange"},
-            {3, &IFile::SetSize, "SetSize"}, 
-            {4, &IFile::GetSize, "GetSize"},
-            {5, nullptr, "OperateRange"},
         };
         RegisterHandlers(functions);
     }

src/core/hle/service/friend/friend.h

@@ -15,7 +15,7 @@ public:
     public:
         Interface(std::shared_ptr<Module> module, const char* name);
 
-        void Unknown(Kernel::HLERequestContext& ctx);
+        void CreateFriendService(Kernel::HLERequestContext& ctx);
 
     protected:
         std::shared_ptr<Module> module;

src/core/hle/service/nvdrv/nvmemp.h

@@ -15,8 +15,8 @@ public:
     ~NVMEMP() = default;
 
 private:
-    void Unknown0(Kernel::HLERequestContext& ctx);
+    void Cmd0(Kernel::HLERequestContext& ctx);
-    void Unknown1(Kernel::HLERequestContext& ctx);
+    void Cmd1(Kernel::HLERequestContext& ctx);
 };
 
 } // namespace Nvidia

src/core/hle/service/pctl/pctl_a.cpp

@@ -108,8 +108,8 @@ public:
             {2016, nullptr, "RequestUpdateExemptionListAsync"},
         };
         RegisterHandlers(functions);
-}
+    }
-
+};
 void PCTL_A::CreateService(Kernel::HLERequestContext& ctx) {
     IPC::ResponseBuilder rb{ctx, 2, 0, 1};
     rb.Push(RESULT_SUCCESS);

src/core/hle/service/pctl/pctl_a.h

@@ -15,7 +15,7 @@ public:
     ~PCTL_A() = default;
 
 private:
-    void GetService(Kernel::HLERequestContext& ctx);
+    void CreateService(Kernel::HLERequestContext& ctx);
 };
 
 } // namespace PCTL