ahmed2007/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

fix: image views segfaulting

Browse source
This commit is contained in:
Samuliak 2024-10-06 19:35:15 +02:00
parent d6148b194e
commit 79e86ed1b6
Signed by: SamoZ1024
SSH key fingerprint: SHA256:DzAyqSLcY9riM0l9Z8qk0O40RLCHv1CjeidYEGoXJKk
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/video_core/renderer_metal/mtl_texture_cache.cpp
View file

@ -122,17 +122,16 @@ ImageView::ImageView(TextureCacheRuntime& runtime, const VideoCommon::ImageViewI
ImageId image_id_, Image& image)
: VideoCommon::ImageViewBase{info, image.info, image_id_, image.gpu_addr} {
using Shader::TextureType;
if (image.GetHandle()) {
texture = image.GetHandle()->retain();
}
texture = image.GetHandle();
// TODO: create texture view
// TODO: implement
}
// TODO: save slot images
ImageView::ImageView(TextureCacheRuntime& runtime, const VideoCommon::ImageViewInfo& info,
ImageId image_id_, Image& image, const SlotVector<Image>& slot_imgs)
: ImageView(runtime, info, image_id_, image) {
// TODO: save slot images
texture = image.GetHandle();
}
ImageView::ImageView(TextureCacheRuntime&, const VideoCommon::ImageInfo& info,
@ -147,9 +146,8 @@ ImageView::ImageView(TextureCacheRuntime& runtime, const VideoCommon::NullImageV
}
ImageView::~ImageView() {
if (texture) {
texture->release();
}
// TODO: uncomment
// texture->release();
}
Sampler::Sampler(TextureCacheRuntime& runtime, const Tegra::Texture::TSCEntry& tsc) {