ahmed2007/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

game_list: Make CompatibilityList parameter of NavigateToGamedbEntryRequested() a const reference

Browse source 
The compatibility list isn't modified within any of the slots connected
to this signal, so we can make it const to enforce immutability.
This commit is contained in:
Lioncash 2018-09-09 19:35:05 -04:00
parent bd8065295c
commit 73a2d71f44
3 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/yuzu/game_list.h
View file

@ -89,7 +89,8 @@ signals:
void GameChosen(QString game_path);
void ShouldCancelWorker();
void OpenFolderRequested(u64 program_id, GameListOpenTarget target);
void NavigateToGamedbEntryRequested(u64 program_id, CompatibilityList& compatibility_list);
void NavigateToGamedbEntryRequested(u64 program_id,
const CompatibilityList& compatibility_list);
private slots:
void onTextChanged(const QString& newText);

2
src/yuzu/main.cpp
View file

@ -727,7 +727,7 @@ void GMainWindow::OnGameListOpenFolder(u64 program_id, GameListOpenTarget target
}
void GMainWindow::OnGameListNavigateToGamedbEntry(u64 program_id,
CompatibilityList& compatibility_list) {
const CompatibilityList& compatibility_list) {
const auto it = FindMatchingCompatibilityEntry(compatibility_list, program_id);
QString directory;

3
src/yuzu/main.h
View file

@ -138,7 +138,8 @@ private slots:
/// Called whenever a user selects a game in the game list widget.
void OnGameListLoadFile(QString game_path);
void OnGameListOpenFolder(u64 program_id, GameListOpenTarget target);
void OnGameListNavigateToGamedbEntry(u64 program_id, CompatibilityList& compatibility_list);
void OnGameListNavigateToGamedbEntry(u64 program_id,
const CompatibilityList& compatibility_list);
void OnMenuLoadFile();
void OnMenuLoadFolder();
void OnMenuInstallToNAND();