ahmed2007/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

cubeb_sink: ignore null-name device when selecting

Browse source 
We already ignore them on listing devices. We should do the same when selecting devices. This fix a crash when opening a specific device while there is a null device in the list
This commit is contained in:
Weiyi Wang 2018-10-26 00:32:41 -04:00 committed by fearlessTobi
parent d278f25bda
commit 12c365b549
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/audio_core/cubeb_sink.cpp
View file

@ -121,7 +121,8 @@ CubebSink::CubebSink(std::string target_device_name) {
const auto collection_end{collection.device + collection.count}; const auto collection_end{collection.device + collection.count};
const auto device{ const auto device{
std::find_if(collection.device, collection_end, [&](const cubeb_device_info& info) { std::find_if(collection.device, collection_end, [&](const cubeb_device_info& info) {
return target_device_name == info.friendly_name; return info.friendly_name != nullptr &&
target_device_name == info.friendly_name;
})}; })};
if (device != collection_end) { if (device != collection_end) {
output_device = device->devid; output_device = device->devid;