Recent changes to the build system that made more warnings be flagged as errors caused building via clang to break. Fixes #4795
Now that clang-format makes [[nodiscard]] attributes format sensibly, we can apply them to several functions within the common library to allow the compiler to complain about any misuses of the functions.
