From e88dc7fc6d329697908a54d14d0e53f40d038655 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Thu, 20 Aug 2015 04:28:39 -0400 Subject: [PATCH] emitter: Remove unused code --- src/common/x64/emitter.cpp | 24 ------------------------ src/common/x64/emitter.h | 20 -------------------- 2 files changed, 44 deletions(-) diff --git a/src/common/x64/emitter.cpp b/src/common/x64/emitter.cpp index 99c682a115..1229d0654e 100644 --- a/src/common/x64/emitter.cpp +++ b/src/common/x64/emitter.cpp @@ -512,30 +512,6 @@ void XEmitter::SetJumpTarget(const FixupBranch& branch) } } -// INC/DEC considered harmful on newer CPUs due to partial flag set. -// Use ADD, SUB instead. - -/* -void XEmitter::INC(int bits, OpArg arg) -{ - if (arg.IsImm()) ASSERT_MSG(0, "INC - Imm argument"); - arg.operandReg = 0; - if (bits == 16) {Write8(0x66);} - arg.WriteRex(this, bits, bits); - Write8(bits == 8 ? 0xFE : 0xFF); - arg.WriteRest(this); -} -void XEmitter::DEC(int bits, OpArg arg) -{ - if (arg.IsImm()) ASSERT_MSG(0, "DEC - Imm argument"); - arg.operandReg = 1; - if (bits == 16) {Write8(0x66);} - arg.WriteRex(this, bits, bits); - Write8(bits == 8 ? 0xFE : 0xFF); - arg.WriteRest(this); -} -*/ - //Single byte opcodes //There is no PUSHAD/POPAD in 64-bit mode. void XEmitter::INT3() {Write8(0xCC);} diff --git a/src/common/x64/emitter.h b/src/common/x64/emitter.h index aa1ead4cab..86f4a1fff0 100644 --- a/src/common/x64/emitter.h +++ b/src/common/x64/emitter.h @@ -328,8 +328,6 @@ enum SSECompare ORD, }; -typedef const u8* JumpTarget; - class XEmitter { friend struct OpArg; // for Write8 etc @@ -434,7 +432,6 @@ public: void CALLptr(OpArg arg); FixupBranch J_CC(CCFlags conditionCode, bool force5bytes = false); - //void J_CC(CCFlags conditionCode, JumpTarget target); void J_CC(CCFlags conditionCode, const u8* addr, bool force5Bytes = false); void SetJumpTarget(const FixupBranch& branch); @@ -640,23 +637,6 @@ public: // SSE/SSE2: Useful alternative to shuffle in some cases. void MOVDDUP(X64Reg regOp, const OpArg& arg); - // TODO: Actually implement -#if 0 - // SSE3: Horizontal operations in SIMD registers. Could be useful for various VFPU things like dot products... - void ADDSUBPS(X64Reg dest, const OpArg& src); - void ADDSUBPD(X64Reg dest, const OpArg& src); - void HADDPD(X64Reg dest, const OpArg& src); - void HSUBPS(X64Reg dest, const OpArg& src); - void HSUBPD(X64Reg dest, const OpArg& src); - - // SSE4: Further horizontal operations - dot products. These are weirdly flexible, the arg contains both a read mask and a write "mask". - void DPPD(X64Reg dest, const OpArg& src, u8 arg); - - // These are probably useful for VFPU emulation. - void INSERTPS(X64Reg dest, const OpArg& src, u8 arg); - void EXTRACTPS(const OpArg& dest, X64Reg src, u8 arg); -#endif - // SSE3: Horizontal operations in SIMD registers. Very slow! shufps-based code beats it handily on Ivy. void HADDPS(X64Reg dest, const OpArg& src);