From 74790e4f33b5d287859ae91df984753eaa84aa28 Mon Sep 17 00:00:00 2001
From: Morph <39850852+Morph1984@users.noreply.github.com>
Date: Sun, 13 Jun 2021 10:55:59 -0400
Subject: [PATCH] common: fs: file: Remove redundant call to WriteStringToFile

The Append open mode will create a new file if said file does not exist at a given path, making this call redundant.
---
 src/common/fs/file.cpp | 4 ----
 src/common/fs/file.h   | 3 +--
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/common/fs/file.cpp b/src/common/fs/file.cpp
index 9f3de1cb03..a12836a0c4 100644
--- a/src/common/fs/file.cpp
+++ b/src/common/fs/file.cpp
@@ -183,10 +183,6 @@ size_t WriteStringToFile(const std::filesystem::path& path, FileType type,
 
 size_t AppendStringToFile(const std::filesystem::path& path, FileType type,
                           std::string_view string) {
-    if (!Exists(path)) {
-        return WriteStringToFile(path, type, string);
-    }
-
     if (!IsFile(path)) {
         return 0;
     }
diff --git a/src/common/fs/file.h b/src/common/fs/file.h
index 50e270c5b8..0f10b60030 100644
--- a/src/common/fs/file.h
+++ b/src/common/fs/file.h
@@ -71,7 +71,7 @@ template <typename Path>
 
 /**
  * Writes a string to a file at path and returns the number of characters successfully written.
- * If an file already exists at path, its contents will be erased.
+ * If a file already exists at path, its contents will be erased.
  * If the filesystem object at path is not a file, this function returns 0.
  *
  * @param path Filesystem path
@@ -95,7 +95,6 @@ template <typename Path>
 
 /**
  * Appends a string to a file at path and returns the number of characters successfully written.
- * If a file does not exist at path, WriteStringToFile is called instead.
  * If the filesystem object at path is not a file, this function returns 0.
  *
  * @param path Filesystem path