From a61124a9e7f2a6eab7f51c2b4dd30574e62ba25a Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Tue, 24 Jul 2018 02:45:23 -0400
Subject: [PATCH 1/2] time: Simplify interface creation

We can use one instance of the interface instead of duplicating code.
---
 src/core/CMakeLists.txt                       |  6 ++--
 .../time/{time_s.cpp => interface.cpp}        | 15 ++++-----
 .../service/time/{time_s.h => interface.h}    |  4 +--
 src/core/hle/service/time/time.cpp            |  7 ++---
 src/core/hle/service/time/time_u.cpp          | 31 -------------------
 src/core/hle/service/time/time_u.h            | 16 ----------
 6 files changed, 15 insertions(+), 64 deletions(-)
 rename src/core/hle/service/time/{time_s.cpp => interface.cpp} (65%)
 rename src/core/hle/service/time/{time_s.h => interface.h} (68%)
 delete mode 100644 src/core/hle/service/time/time_u.cpp
 delete mode 100644 src/core/hle/service/time/time_u.h

diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt
index 6b6efbc00f..028095ff98 100644
--- a/src/core/CMakeLists.txt
+++ b/src/core/CMakeLists.txt
@@ -235,12 +235,10 @@ add_library(core STATIC
     hle/service/spl/spl.h
     hle/service/ssl/ssl.cpp
     hle/service/ssl/ssl.h
+    hle/service/time/interface.cpp
+    hle/service/time/interface.h
     hle/service/time/time.cpp
     hle/service/time/time.h
-    hle/service/time/time_s.cpp
-    hle/service/time/time_s.h
-    hle/service/time/time_u.cpp
-    hle/service/time/time_u.h
     hle/service/vi/vi.cpp
     hle/service/vi/vi.h
     hle/service/vi/vi_m.cpp
diff --git a/src/core/hle/service/time/time_s.cpp b/src/core/hle/service/time/interface.cpp
similarity index 65%
rename from src/core/hle/service/time/time_s.cpp
rename to src/core/hle/service/time/interface.cpp
index 0b599ea001..e61788db80 100644
--- a/src/core/hle/service/time/time_s.cpp
+++ b/src/core/hle/service/time/interface.cpp
@@ -2,17 +2,18 @@
 // Licensed under GPLv2 or any later version
 // Refer to the license.txt file included.
 
-#include "core/hle/service/time/time_s.h"
+#include "core/hle/service/time/interface.h"
 
 namespace Service::Time {
 
-TIME_S::TIME_S(std::shared_ptr<Module> time) : Module::Interface(std::move(time), "time:s") {
+TIME::TIME(std::shared_ptr<Module> time, const char* name)
+    : Module::Interface(std::move(time), name) {
     static const FunctionInfo functions[] = {
-        {0, &TIME_S::GetStandardUserSystemClock, "GetStandardUserSystemClock"},
-        {1, &TIME_S::GetStandardNetworkSystemClock, "GetStandardNetworkSystemClock"},
-        {2, &TIME_S::GetStandardSteadyClock, "GetStandardSteadyClock"},
-        {3, &TIME_S::GetTimeZoneService, "GetTimeZoneService"},
-        {4, &TIME_S::GetStandardLocalSystemClock, "GetStandardLocalSystemClock"},
+        {0, &TIME::GetStandardUserSystemClock, "GetStandardUserSystemClock"},
+        {1, &TIME::GetStandardNetworkSystemClock, "GetStandardNetworkSystemClock"},
+        {2, &TIME::GetStandardSteadyClock, "GetStandardSteadyClock"},
+        {3, &TIME::GetTimeZoneService, "GetTimeZoneService"},
+        {4, &TIME::GetStandardLocalSystemClock, "GetStandardLocalSystemClock"},
         {5, nullptr, "GetEphemeralNetworkSystemClock"},
         {50, nullptr, "SetStandardSteadyClockInternalOffset"},
         {100, nullptr, "IsStandardUserSystemClockAutomaticCorrectionEnabled"},
diff --git a/src/core/hle/service/time/time_s.h b/src/core/hle/service/time/interface.h
similarity index 68%
rename from src/core/hle/service/time/time_s.h
rename to src/core/hle/service/time/interface.h
index 4a2daa513a..0f97cec350 100644
--- a/src/core/hle/service/time/time_s.h
+++ b/src/core/hle/service/time/interface.h
@@ -8,9 +8,9 @@
 
 namespace Service::Time {
 
-class TIME_S final : public Module::Interface {
+class TIME final : public Module::Interface {
 public:
-    explicit TIME_S(std::shared_ptr<Module> time);
+    explicit TIME(std::shared_ptr<Module> time, const char* name);
 };
 
 } // namespace Service::Time
diff --git a/src/core/hle/service/time/time.cpp b/src/core/hle/service/time/time.cpp
index 507ae95f4e..dbaa661bbe 100644
--- a/src/core/hle/service/time/time.cpp
+++ b/src/core/hle/service/time/time.cpp
@@ -9,9 +9,8 @@
 #include "core/hle/ipc_helpers.h"
 #include "core/hle/kernel/client_port.h"
 #include "core/hle/kernel/client_session.h"
+#include "core/hle/service/time/interface.h"
 #include "core/hle/service/time/time.h"
-#include "core/hle/service/time/time_s.h"
-#include "core/hle/service/time/time_u.h"
 
 namespace Service::Time {
 
@@ -212,8 +211,8 @@ Module::Interface::Interface(std::shared_ptr<Module> time, const char* name)
 
 void InstallInterfaces(SM::ServiceManager& service_manager) {
     auto time = std::make_shared<Module>();
-    std::make_shared<TIME_S>(time)->InstallAsService(service_manager);
-    std::make_shared<TIME_U>(time)->InstallAsService(service_manager);
+    std::make_shared<TIME>(time, "time:s")->InstallAsService(service_manager);
+    std::make_shared<TIME>(time, "time:u")->InstallAsService(service_manager);
 }
 
 } // namespace Service::Time
diff --git a/src/core/hle/service/time/time_u.cpp b/src/core/hle/service/time/time_u.cpp
deleted file mode 100644
index 1ed42c4192..0000000000
--- a/src/core/hle/service/time/time_u.cpp
+++ /dev/null
@@ -1,31 +0,0 @@
-// Copyright 2018 yuzu emulator team
-// Licensed under GPLv2 or any later version
-// Refer to the license.txt file included.
-
-#include "core/hle/service/time/time_u.h"
-
-namespace Service::Time {
-
-TIME_U::TIME_U(std::shared_ptr<Module> time) : Module::Interface(std::move(time), "time:u") {
-    static const FunctionInfo functions[] = {
-        {0, &TIME_U::GetStandardUserSystemClock, "GetStandardUserSystemClock"},
-        {1, &TIME_U::GetStandardNetworkSystemClock, "GetStandardNetworkSystemClock"},
-        {2, &TIME_U::GetStandardSteadyClock, "GetStandardSteadyClock"},
-        {3, &TIME_U::GetTimeZoneService, "GetTimeZoneService"},
-        {4, &TIME_U::GetStandardLocalSystemClock, "GetStandardLocalSystemClock"},
-        {5, nullptr, "GetEphemeralNetworkSystemClock"},
-        {50, nullptr, "SetStandardSteadyClockInternalOffset"},
-        {100, nullptr, "IsStandardUserSystemClockAutomaticCorrectionEnabled"},
-        {101, nullptr, "SetStandardUserSystemClockAutomaticCorrectionEnabled"},
-        {102, nullptr, "GetStandardUserSystemClockInitialYear"},
-        {200, nullptr, "IsStandardNetworkSystemClockAccuracySufficient"},
-        {300, nullptr, "CalculateMonotonicSystemClockBaseTimePoint"},
-        {400, nullptr, "GetClockSnapshot"},
-        {401, nullptr, "GetClockSnapshotFromSystemClockContext"},
-        {500, nullptr, "CalculateStandardUserSystemClockDifferenceByUser"},
-        {501, nullptr, "CalculateSpanBetween"},
-    };
-    RegisterHandlers(functions);
-}
-
-} // namespace Service::Time
diff --git a/src/core/hle/service/time/time_u.h b/src/core/hle/service/time/time_u.h
deleted file mode 100644
index 3724bcdc74..0000000000
--- a/src/core/hle/service/time/time_u.h
+++ /dev/null
@@ -1,16 +0,0 @@
-// Copyright 2018 yuzu emulator team
-// Licensed under GPLv2 or any later version
-// Refer to the license.txt file included.
-
-#pragma once
-
-#include "core/hle/service/time/time.h"
-
-namespace Service::Time {
-
-class TIME_U final : public Module::Interface {
-public:
-    explicit TIME_U(std::shared_ptr<Module> time);
-};
-
-} // namespace Service::Time

From 3c1cb3b11e84aae62b4a16a139fab62c3b697e4c Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Tue, 24 Jul 2018 02:47:41 -0400
Subject: [PATCH 2/2] time: Add the time:a service

Given we already have time:s and time:u, we should also have time:a
---
 src/core/hle/service/time/interface.cpp | 12 ++++++------
 src/core/hle/service/time/interface.h   |  4 ++--
 src/core/hle/service/time/time.cpp      |  5 +++--
 3 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/src/core/hle/service/time/interface.cpp b/src/core/hle/service/time/interface.cpp
index e61788db80..048d5b0777 100644
--- a/src/core/hle/service/time/interface.cpp
+++ b/src/core/hle/service/time/interface.cpp
@@ -6,14 +6,14 @@
 
 namespace Service::Time {
 
-TIME::TIME(std::shared_ptr<Module> time, const char* name)
+Time::Time(std::shared_ptr<Module> time, const char* name)
     : Module::Interface(std::move(time), name) {
     static const FunctionInfo functions[] = {
-        {0, &TIME::GetStandardUserSystemClock, "GetStandardUserSystemClock"},
-        {1, &TIME::GetStandardNetworkSystemClock, "GetStandardNetworkSystemClock"},
-        {2, &TIME::GetStandardSteadyClock, "GetStandardSteadyClock"},
-        {3, &TIME::GetTimeZoneService, "GetTimeZoneService"},
-        {4, &TIME::GetStandardLocalSystemClock, "GetStandardLocalSystemClock"},
+        {0, &Time::GetStandardUserSystemClock, "GetStandardUserSystemClock"},
+        {1, &Time::GetStandardNetworkSystemClock, "GetStandardNetworkSystemClock"},
+        {2, &Time::GetStandardSteadyClock, "GetStandardSteadyClock"},
+        {3, &Time::GetTimeZoneService, "GetTimeZoneService"},
+        {4, &Time::GetStandardLocalSystemClock, "GetStandardLocalSystemClock"},
         {5, nullptr, "GetEphemeralNetworkSystemClock"},
         {50, nullptr, "SetStandardSteadyClockInternalOffset"},
         {100, nullptr, "IsStandardUserSystemClockAutomaticCorrectionEnabled"},
diff --git a/src/core/hle/service/time/interface.h b/src/core/hle/service/time/interface.h
index 0f97cec350..183a53db13 100644
--- a/src/core/hle/service/time/interface.h
+++ b/src/core/hle/service/time/interface.h
@@ -8,9 +8,9 @@
 
 namespace Service::Time {
 
-class TIME final : public Module::Interface {
+class Time final : public Module::Interface {
 public:
-    explicit TIME(std::shared_ptr<Module> time, const char* name);
+    explicit Time(std::shared_ptr<Module> time, const char* name);
 };
 
 } // namespace Service::Time
diff --git a/src/core/hle/service/time/time.cpp b/src/core/hle/service/time/time.cpp
index dbaa661bbe..e32c088e81 100644
--- a/src/core/hle/service/time/time.cpp
+++ b/src/core/hle/service/time/time.cpp
@@ -211,8 +211,9 @@ Module::Interface::Interface(std::shared_ptr<Module> time, const char* name)
 
 void InstallInterfaces(SM::ServiceManager& service_manager) {
     auto time = std::make_shared<Module>();
-    std::make_shared<TIME>(time, "time:s")->InstallAsService(service_manager);
-    std::make_shared<TIME>(time, "time:u")->InstallAsService(service_manager);
+    std::make_shared<Time>(time, "time:a")->InstallAsService(service_manager);
+    std::make_shared<Time>(time, "time:s")->InstallAsService(service_manager);
+    std::make_shared<Time>(time, "time:u")->InstallAsService(service_manager);
 }
 
 } // namespace Service::Time